Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49495][DOCS] Document and Feature Preview on the master branch via Live GitHub Pages Updates #48175

Closed
wants to merge 7 commits into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Sep 20, 2024

What changes were proposed in this pull request?

This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'.

Why are the changes needed?

retore
8861f0f
3763827
58d73fe

Does this PR introduce any user-facing change?

No

How was this patch tested?

https://github.com/yaooqinn/spark/actions/runs/10952355999

Was this patch authored or co-authored using generative AI tooling?

no

…he master branch via Live GitHub Pages Updates""

This reverts commit 8861f0f.
… for GitHub Pages publication action""

This reverts commit 3763827.
…h via Live GitHub Pages Updates

    ### What changes were proposed in this pull request?

    This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pa
ges Updates'.

    ### Why are the changes needed?

    - Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify
the documentation contents.
    - Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoin
g documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during
the final upgrades.

    ### Does this PR introduce _any_ user-facing change?

    No

    ### How was this patch tested?

    An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark
-gh-pages

    - Broken logo links are fixed at apache#47966

    ### Was this patch authored or co-authored using generative AI tooling?
    no
@github-actions github-actions bot added the INFRA label Sep 20, 2024
id-token: write
pages: write
environment:
name: github-pages # https://github.com/actions/deploy-pages/issues/271
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this but wonder if we can make sure this is working before merging it in.

@yaooqinn yaooqinn closed this in bbbc05c Sep 21, 2024
@yaooqinn yaooqinn deleted the SPARK-49495 branch September 21, 2024 11:40
@yaooqinn yaooqinn restored the SPARK-49495 branch September 21, 2024 12:44
@yaooqinn yaooqinn reopened this Sep 21, 2024
@yaooqinn yaooqinn closed this in 4f640e2 Sep 21, 2024
@yaooqinn yaooqinn deleted the SPARK-49495 branch September 21, 2024 16:53
@yaooqinn
Copy link
Member Author

Merged to master.

The website is now live. https://apache.github.io/spark/

BTW, This patch also brings the unexpected action alive again. I will ask INFRA to disable it one more time

@dongjoon-hyun
Copy link
Member

Ack. That's too bad. Ya, it would be great if we can recover it soon.
Thank you, @yaooqinn .

@HyukjinKwon
Copy link
Member

Thanks for doing this!

@yaooqinn
Copy link
Member Author

The INFRA team has terminated these unexpected actions.

FYI,https://issues.apache.org/jira/browse/INFRA-26133

attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
… via Live GitHub Pages Updates

### What changes were proposed in this pull request?

This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'.

### Why are the changes needed?

retore
8861f0f
3763827
58d73fe

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

https://github.com/yaooqinn/spark/actions/runs/10952355999

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#48175 from yaooqinn/SPARK-49495.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
… via Live GitHub Pages Updates

### What changes were proposed in this pull request?

This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'.

### Why are the changes needed?

retore
8861f0f
3763827
58d73fe

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

https://github.com/yaooqinn/spark/actions/runs/10952355999

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#48175 from yaooqinn/SPARK-49495.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants