Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-46698][CORE][3.5] Replace Timer with single thread scheduled executor for ConsoleProgressBar #47957

Open
wants to merge 1 commit into
base: branch-3.5
Choose a base branch
from
Open

[SPARK-46698][CORE][3.5] Replace Timer with single thread scheduled executor for ConsoleProgressBar #47957

wants to merge 1 commit into from

Commits on Sep 2, 2024

  1. [SPARK-46698][CORE] Replace Timer with single thread scheduled execut… 

    …or for ConsoleProgressBar

### What changes were proposed in this pull request?
This PR propose to replace `Timer` with single thread scheduled executor for `ConsoleProgressBar`.

### Why are the changes needed?
The javadoc recommends `ScheduledThreadPoolExecutor` instead of `Timer`.
![屏幕快照 2024-01-12 下午12 47 57](https://github.com/apache/spark/assets/8486025/4fc5ed61-6bb9-4768-915a-ad919a067d04)

This change based on the following two points.
**System time sensitivity**

Timer scheduling is based on the absolute time of the operating system and is sensitive to the operating system's time. Once the operating system's time changes, Timer scheduling is no longer precise.
The scheduled Thread Pool Executor scheduling is based on relative time and is not affected by changes in operating system time.

**Are anomalies captured**

Timer does not capture exceptions thrown by Timer Tasks, and in addition, Timer is single threaded. Once a scheduling task encounters an exception, the entire thread will terminate and other tasks that need to be scheduled will no longer be executed.
The scheduled Thread Pool Executor implements scheduling functions based on a thread pool. After a task throws an exception, other tasks can still execute normally.

### Does this PR introduce _any_ user-facing change?
'No'.

### How was this patch tested?
Manual tests.

### Was this patch authored or co-authored using generative AI tooling?
'No'.

Closes apache#44701 from beliefer/replace-timer-with-scheduled-executor.

Authored-by: beliefer <beliefer@163.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit fc66576)
    @beliefer @jshmchenxi
    beliefer authored and jshmchenxi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f690e5d View commit details
    Browse the repository at this point in the history