[SPARK-49381][K8S][TESTS] Fix SPARK-41388 test case to assert the result
#47865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Aug 26, 2024
| @@ -853,7 +853,7 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter { | |||
| pvc2.getMetadata.setCreationTimestamp(now.toString) | |||
|
|
|||
| when(persistentVolumeClaimList.getItems).thenReturn(Seq(pvc1, pvc2).asJava) | |||
| podsAllocatorUnderTest invokePrivate getReusablePVCs("appId", Seq("pvc-1")) | |||
There was a problem hiding this comment.
Previously, we only invoke the target method and didn't check the result.
|
All tests passed. |
dongjoon-hyun
commented
Aug 26, 2024
| val pvc1 = persistentVolumeClaim("pvc-0", "gp2", "200Gi") | ||
| val pvc2 = persistentVolumeClaim("pvc-1", "gp2", "200Gi") | ||
| val pvc1 = persistentVolumeClaim("pvc-1", "gp2", "200Gi") | ||
| val pvc2 = persistentVolumeClaim("pvc-2", "gp2", "200Gi") |
There was a problem hiding this comment.
The PVC names are revised to match with the variable names.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
HyukjinKwon
approved these changes
Aug 26, 2024
yaooqinn
approved these changes
Aug 26, 2024
|
Thank you, @HyukjinKwon and @yaooqinn . Merged to master/3.5/3.4. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 26, 2024
…esult ### What changes were proposed in this pull request? This PR aims to fix a test case of SPARK-41388 by adding a missed assert. ### Why are the changes needed? To check the result correctly. ### Does this PR introduce _any_ user-facing change? No, this is a test case change. ### How was this patch tested? Pass the CIs with newly added assertion. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47865 from dongjoon-hyun/SPARK-49381. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5706942) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 26, 2024
…esult ### What changes were proposed in this pull request? This PR aims to fix a test case of SPARK-41388 by adding a missed assert. ### Why are the changes needed? To check the result correctly. ### Does this PR introduce _any_ user-facing change? No, this is a test case change. ### How was this patch tested? Pass the CIs with newly added assertion. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47865 from dongjoon-hyun/SPARK-49381. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5706942) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…esult ### What changes were proposed in this pull request? This PR aims to fix a test case of SPARK-41388 by adding a missed assert. ### Why are the changes needed? To check the result correctly. ### Does this PR introduce _any_ user-facing change? No, this is a test case change. ### How was this patch tested? Pass the CIs with newly added assertion. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47865 from dongjoon-hyun/SPARK-49381. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Sep 24, 2024
…esult ### What changes were proposed in this pull request? This PR aims to fix a test case of SPARK-41388 by adding a missed assert. ### Why are the changes needed? To check the result correctly. ### Does this PR introduce _any_ user-facing change? No, this is a test case change. ### How was this patch tested? Pass the CIs with newly added assertion. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47865 from dongjoon-hyun/SPARK-49381. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5706942) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…esult ### What changes were proposed in this pull request? This PR aims to fix a test case of SPARK-41388 by adding a missed assert. ### Why are the changes needed? To check the result correctly. ### Does this PR introduce _any_ user-facing change? No, this is a test case change. ### How was this patch tested? Pass the CIs with newly added assertion. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47865 from dongjoon-hyun/SPARK-49381. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix a test case of SPARK-41388 by adding a missed assert.
Why are the changes needed?
To check the result correctly.
Does this PR introduce any user-facing change?
No, this is a test case change.
How was this patch tested?
Pass the CIs with newly added assertion.
Was this patch authored or co-authored using generative AI tooling?
No.