[SPARK-48996][SQL][PYTHON] Allow bare literals for __and__ and __or__ of Column #47474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
changed the title
itholic
approved these changes
Jul 25, 2024
HyukjinKwon
approved these changes
Jul 25, 2024
zhengruifeng
approved these changes
Jul 25, 2024
|
The failure seems not related to this PR. |
|
Thanks! merging to master. |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
… of Column
### What changes were proposed in this pull request?
Allows bare literals for `__and__` and `__or__` of Column API in Spark Classic.
### Why are the changes needed?
Currently bare literals are not allowed for `__and__` and `__or__` of Column API in Spark Classic and need to wrap with `lit()` function. It should be allowed similar to other similar operators.
```py
>>> from pyspark.sql.functions import *
>>> c = col("c")
>>> c & True
Traceback (most recent call last):
...
py4j.Py4JException: Method and([class java.lang.Boolean]) does not exist
>>> c & lit(True)
Column<'and(c, true)'>
```
whereas other operators:
```py
>>> c + 1
Column<'`+`(c, 1)'>
>>> c + lit(1)
Column<'`+`(c, 1)'>
```
Spark Connect allows this.
```py
>>> c & True
Column<'and(c, True)'>
>>> c & lit(True)
Column<'and(c, True)'>
```
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Added the related tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47474 from ueshin/issues/SPARK-48996/literal_and_or.
Authored-by: Takuya Ueshin <ueshin@databricks.com>
Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
fusheng-rd
pushed a commit
to fusheng-rd/spark
that referenced
this pull request
Aug 6, 2024
… of Column
### What changes were proposed in this pull request?
Allows bare literals for `__and__` and `__or__` of Column API in Spark Classic.
### Why are the changes needed?
Currently bare literals are not allowed for `__and__` and `__or__` of Column API in Spark Classic and need to wrap with `lit()` function. It should be allowed similar to other similar operators.
```py
>>> from pyspark.sql.functions import *
>>> c = col("c")
>>> c & True
Traceback (most recent call last):
...
py4j.Py4JException: Method and([class java.lang.Boolean]) does not exist
>>> c & lit(True)
Column<'and(c, true)'>
```
whereas other operators:
```py
>>> c + 1
Column<'`+`(c, 1)'>
>>> c + lit(1)
Column<'`+`(c, 1)'>
```
Spark Connect allows this.
```py
>>> c & True
Column<'and(c, True)'>
>>> c & lit(True)
Column<'and(c, True)'>
```
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Added the related tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47474 from ueshin/issues/SPARK-48996/literal_and_or.
Authored-by: Takuya Ueshin <ueshin@databricks.com>
Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
… of Column
### What changes were proposed in this pull request?
Allows bare literals for `__and__` and `__or__` of Column API in Spark Classic.
### Why are the changes needed?
Currently bare literals are not allowed for `__and__` and `__or__` of Column API in Spark Classic and need to wrap with `lit()` function. It should be allowed similar to other similar operators.
```py
>>> from pyspark.sql.functions import *
>>> c = col("c")
>>> c & True
Traceback (most recent call last):
...
py4j.Py4JException: Method and([class java.lang.Boolean]) does not exist
>>> c & lit(True)
Column<'and(c, true)'>
```
whereas other operators:
```py
>>> c + 1
Column<'`+`(c, 1)'>
>>> c + lit(1)
Column<'`+`(c, 1)'>
```
Spark Connect allows this.
```py
>>> c & True
Column<'and(c, True)'>
>>> c & lit(True)
Column<'and(c, True)'>
```
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Added the related tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47474 from ueshin/issues/SPARK-48996/literal_and_or.
Authored-by: Takuya Ueshin <ueshin@databricks.com>
Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allows bare literals for
__and__and__or__of Column API in Spark Classic.Why are the changes needed?
Currently bare literals are not allowed for
__and__and__or__of Column API in Spark Classic and need to wrap withlit()function. It should be allowed similar to other similar operators.whereas other operators:
Spark Connect allows this.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Added the related tests.
Was this patch authored or co-authored using generative AI tooling?
No.