[SPARK-48981] Fix simpleString method of StringType in pyspark for collations #47463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
approved these changes
Jul 23, 2024
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Can we change the PR title to 'Fix simpleString method of StringType in PySpark for collations'?
stefankandic
changed the title
Contributor
Author
done! |
HyukjinKwon
approved these changes
Jul 24, 2024
Member
|
Merged to master. |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
…llations ### What changes were proposed in this pull request? Fixing the bug in the code where because of different way string interpolation works in python we had an accidental dollar sign in the string value. ### Why are the changes needed? To be consistent with the scala code. ### Does this PR introduce _any_ user-facing change? Different value will be shown to the user. ### How was this patch tested? Unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47463 from stefankandic/fixPythonToString. Authored-by: Stefan Kandic <stefan.kandic@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixing the bug in the code where because of different way string interpolation works in python we had an accidental dollar sign in the string value.
Why are the changes needed?
To be consistent with the scala code.
Does this PR introduce any user-facing change?
Different value will be shown to the user.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.