[SPARK-48975][PROTOBUF] Remove unnecessary ScalaReflectionLock definition from protobuf
#47459
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jul 23, 2024
| */ | ||
| package org.apache.spark.sql | ||
|
|
||
| package object protobuf { |
Contributor
Author
There was a problem hiding this comment.
There are other empty package object definitions within the Spark internal code, such as
and
spark/core/src/main/scala/org/apache/spark/util/random/package.scala
Lines 18 to 23 in 285489b
Therefore, in this PR, only the definition of ·ScalaReflectionLock· was removed while the package object protobuf was retained.
Member
|
Merged to master for Apache Spark 4.0.0-preview2. |
Contributor
Author
|
Thanks @dongjoon-hyun ~ |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
…nition from `protobuf` ### What changes were proposed in this pull request? This PR removes the unused object definition `ScalaReflectionLock` from the `protobuf` module. `ScalaReflectionLock` is a definition at the access scope of `protobuf` package, which was defined in SPARK-40654 | apache#37972 and become unused in SPARK-41639 | apache#39147. ### Why are the changes needed? Clean up unused definitions. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47459 from LuciferYang/remove-ScalaReflectionLock. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the unused object definition
ScalaReflectionLockfrom theprotobufmodule.ScalaReflectionLockis a definition at the access scope ofprotobufpackage, which was defined in SPARK-40654 | #37972 and become unused in SPARK-41639 | #39147.Why are the changes needed?
Clean up unused definitions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No