[SPARK-48498][SQL][FOLLOWUP] do padding for char-char comparison #47412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yaooqinn |
yaooqinn
reviewed
Jul 19, 2024
| sql(s"CREATE TABLE t2 (c1 CHAR(3), c2 CHAR(5)) USING $format LOCATION '$dir'") | ||
| // Comparing CHAR column with CHAR column compares the padded values. | ||
| checkAnswer( | ||
| sql("SELECT c1 = c2 FROM t2"), |
There was a problem hiding this comment.
Can we test both c1 = c2 and c2 = c1?
yaooqinn
reviewed
Jul 19, 2024
| Seq(Row(true), Row(true), Row(true), Row(true)) | ||
| ) | ||
| checkAnswer( | ||
| sql("SELECT c1 IN (c2) FROM t2"), |
yaooqinn
reviewed
Jul 19, 2024
| (rawType, typeWithTargetCharLength) match { | ||
| case (CharType(len), CharType(target)) if target > len => | ||
| case (CharType(len), CharType(target)) if alwaysPad || target > len => |
There was a problem hiding this comment.
do we need padding if len = target?
There was a problem hiding this comment.
we don't need to. This is the existing logic. My change is always pad as the CHAR value may not be padded to its declared length.
yaooqinn
reviewed
Jul 19, 2024
| (rawType, typeWithTargetCharLength) match { | ||
| case (CharType(len), CharType(target)) if target > len => | ||
| case (CharType(len), CharType(target)) if alwaysPad || target > len => | ||
| Some(StringRPad(expr, Literal(target))) |
There was a problem hiding this comment.
Shall be the bigger number here?
yaooqinn
approved these changes
Jul 19, 2024
|
thanks for review, merging to master/3.5! |
cloud-fan
added a commit
that referenced
this pull request
Jul 19, 2024
### What changes were proposed in this pull request? This is a followup of #46832 to handle a missing case: char-char comparison. We should pad both sides if `READ_SIDE_CHAR_PADDING` is not enabled. ### Why are the changes needed? bug fix if people disable read side char padding ### Does this PR introduce _any_ user-facing change? No because it's a followup and the original PR is not released yet ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #47412 from cloud-fan/char. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? This is a followup of apache#46832 to handle a missing case: char-char comparison. We should pad both sides if `READ_SIDE_CHAR_PADDING` is not enabled. ### Why are the changes needed? bug fix if people disable read side char padding ### Does this PR introduce _any_ user-facing change? No because it's a followup and the original PR is not released yet ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47412 from cloud-fan/char. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This is a followup of apache#46832 to handle a missing case: char-char comparison. We should pad both sides if `READ_SIDE_CHAR_PADDING` is not enabled. ### Why are the changes needed? bug fix if people disable read side char padding ### Does this PR introduce _any_ user-facing change? No because it's a followup and the original PR is not released yet ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47412 from cloud-fan/char. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? This is a followup of apache#46832 to handle a missing case: char-char comparison. We should pad both sides if `READ_SIDE_CHAR_PADDING` is not enabled. ### Why are the changes needed? bug fix if people disable read side char padding ### Does this PR introduce _any_ user-facing change? No because it's a followup and the original PR is not released yet ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47412 from cloud-fan/char. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #46832 to handle a missing case: char-char comparison. We should pad both sides if
READ_SIDE_CHAR_PADDINGis not enabled.Why are the changes needed?
bug fix if people disable read side char padding
Does this PR introduce any user-facing change?
No because it's a followup and the original PR is not released yet
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no