[SPARK-48759][SQL] Add migration doc for CREATE TABLE AS SELECT behavior change behavior change since Spark 3.4 (branch-3.5) #47178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
|
thanks, merging to 3.5/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ior change behavior change since Spark 3.4 (branch-3.5) ### What changes were proposed in this pull request? This PR is a follow-up to #47152 against `branch-3.5`. Add migration guide for `CREATE TABLE AS SELECT...` behavior change. SPARK-41859 changes the behaviour for `CREATE TABLE AS SELECT ...` from OVERWRITE to APPEND when `spark.sql.legacy.allowNonEmptyLocationInCTAS` is set to `true`: ``` drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 1 as col union all select 2 as col; drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 3 as col union all select 4 as col; select * from test_table; ``` This produces {3, 4} in Spark <3.4.0 and {1, 2, 3, 4} in Spark 3.4.0 and later. This is a silent change in `spark.sql.legacy.allowNonEmptyLocationInCTAS` behaviour which introduces wrong results in the user application. ### Why are the changes needed? This documents a behavior change starting in Spark 3.4 for `CREATE TABLE AS SELECT` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `doc build ` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47178 from asl3/allowNonEmptyLocationInCTAS-3.5. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ior change behavior change since Spark 3.4 (branch-3.5) ### What changes were proposed in this pull request? This PR is a follow-up to #47152 against `branch-3.5`. Add migration guide for `CREATE TABLE AS SELECT...` behavior change. SPARK-41859 changes the behaviour for `CREATE TABLE AS SELECT ...` from OVERWRITE to APPEND when `spark.sql.legacy.allowNonEmptyLocationInCTAS` is set to `true`: ``` drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 1 as col union all select 2 as col; drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 3 as col union all select 4 as col; select * from test_table; ``` This produces {3, 4} in Spark <3.4.0 and {1, 2, 3, 4} in Spark 3.4.0 and later. This is a silent change in `spark.sql.legacy.allowNonEmptyLocationInCTAS` behaviour which introduces wrong results in the user application. ### Why are the changes needed? This documents a behavior change starting in Spark 3.4 for `CREATE TABLE AS SELECT` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `doc build ` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47178 from asl3/allowNonEmptyLocationInCTAS-3.5. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit ef4e456) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
gaecoli
pushed a commit
to gaecoli/spark
that referenced
this pull request
Jul 10, 2024
…ior change behavior change since Spark 3.4 (branch-3.5) ### What changes were proposed in this pull request? This PR is a follow-up to apache#47152 against `branch-3.5`. Add migration guide for `CREATE TABLE AS SELECT...` behavior change. SPARK-41859 changes the behaviour for `CREATE TABLE AS SELECT ...` from OVERWRITE to APPEND when `spark.sql.legacy.allowNonEmptyLocationInCTAS` is set to `true`: ``` drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 1 as col union all select 2 as col; drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 3 as col union all select 4 as col; select * from test_table; ``` This produces {3, 4} in Spark <3.4.0 and {1, 2, 3, 4} in Spark 3.4.0 and later. This is a silent change in `spark.sql.legacy.allowNonEmptyLocationInCTAS` behaviour which introduces wrong results in the user application. ### Why are the changes needed? This documents a behavior change starting in Spark 3.4 for `CREATE TABLE AS SELECT` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `doc build ` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47178 from asl3/allowNonEmptyLocationInCTAS-3.5. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
…ior change behavior change since Spark 3.4 (branch-3.5) ### What changes were proposed in this pull request? This PR is a follow-up to apache#47152 against `branch-3.5`. Add migration guide for `CREATE TABLE AS SELECT...` behavior change. SPARK-41859 changes the behaviour for `CREATE TABLE AS SELECT ...` from OVERWRITE to APPEND when `spark.sql.legacy.allowNonEmptyLocationInCTAS` is set to `true`: ``` drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 1 as col union all select 2 as col; drop table if exists test_table; create table test_table location '/tmp/test_table' stored as parquet as select 3 as col union all select 4 as col; select * from test_table; ``` This produces {3, 4} in Spark <3.4.0 and {1, 2, 3, 4} in Spark 3.4.0 and later. This is a silent change in `spark.sql.legacy.allowNonEmptyLocationInCTAS` behaviour which introduces wrong results in the user application. ### Why are the changes needed? This documents a behavior change starting in Spark 3.4 for `CREATE TABLE AS SELECT` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `doc build ` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47178 from asl3/allowNonEmptyLocationInCTAS-3.5. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit ef4e456) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up to #47152 against
branch-3.5.Add migration guide for
CREATE TABLE AS SELECT...behavior change.SPARK-41859 changes the behaviour for
CREATE TABLE AS SELECT ...from OVERWRITE to APPEND whenspark.sql.legacy.allowNonEmptyLocationInCTASis set totrue:This produces {3, 4} in Spark <3.4.0 and {1, 2, 3, 4} in Spark 3.4.0 and later. This is a silent change in
spark.sql.legacy.allowNonEmptyLocationInCTASbehaviour which introduces wrong results in the user application.Why are the changes needed?
This documents a behavior change starting in Spark 3.4 for
CREATE TABLE AS SELECTDoes this PR introduce any user-facing change?
No.
How was this patch tested?
doc buildWas this patch authored or co-authored using generative AI tooling?
No.