[SPARK-48639][CONNECT][PYTHON] Add Origin to RelationCommon #47115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….RelationCommon"" This reverts commit 2e31572.
HyukjinKwon
commented
Jun 27, 2024
| // (Required) Shared relation metadata. | ||
| string source_info = 1; | ||
| string source_info = 1 [deprecated=true]; |
There was a problem hiding this comment.
Just switched to deprecation. It breaks the protobuf compat check, and I should backport this change all down to branch-3.4, which isn't worthwhile
There was a problem hiding this comment.
Can we try annotate it with a buf comment?
Something like
// buf:lint:ignore FIELD_NO_DELETE
zhengruifeng
approved these changes
Jun 27, 2024
|
Yup |
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This PR proposes to add `Origin` (from apache#46789) to `Relation.RelationCommon` This is a revert of the revert. ### Why are the changes needed? To have the common protobuf message to keep the source code info. ```diff - // TODO(SPARK-48639): Add origin like Expression.ExpressionCommon - - // (Required) Shared relation metadata. - string source_info = 1; + // (Optional) Shared relation metadata. + reserved 1; ``` This is considered as a breaking change, and we should fix up all other branches down to avoid, which isn't really worthwhile. ### Does this PR introduce _any_ user-facing change? No. This is not used. ### How was this patch tested? CI should validate protobuf definition, and exiting tests should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47115 from HyukjinKwon/SPARK-48639-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add
Origin(from #46789) toRelation.RelationCommonThis is a revert of the revert.
Why are the changes needed?
To have the common protobuf message to keep the source code info.
This is considered as a breaking change, and we should fix up all other branches down to avoid, which isn't really worthwhile.
Does this PR introduce any user-facing change?
No. This is not used.
How was this patch tested?
CI should validate protobuf definition, and exiting tests should pass.
Was this patch authored or co-authored using generative AI tooling?
No.