[SPARK-48695][PYTHON] TimestampNTZType.fromInternal not use the deprecated methods
#47068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Jun 24, 2024
| @@ -434,8 +434,8 @@ def toInternal(self, dt: datetime.datetime) -> int: | |||
| def fromInternal(self, ts: int) -> datetime.datetime: | |||
| if ts is not None: | |||
| # using int to avoid precision loss in float | |||
| return datetime.datetime.utcfromtimestamp(ts // 1000000).replace( | |||
| microsecond=ts % 1000000 | |||
| return datetime.datetime.fromtimestamp(ts // 1000000, datetime.timezone.utc).replace( | |||
There was a problem hiding this comment.
datetime.UTC was added in 3.11, so use datetime.timezone.utc to support 3.9/3.10
HyukjinKwon
approved these changes
Jun 24, 2024
|
merged to master |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…recated methods ### What changes were proposed in this pull request? `TimestampNTZType.fromInternal` not use the deprecated methods ### Why are the changes needed? ``` In [2]: ts = 111111111111 In [3]: datetime.datetime.utcfromtimestamp(ts // 1000000).replace( ...: microsecond=ts % 1000000 ...: ) <ipython-input-3-166450e5ec26>:1: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). datetime.datetime.utcfromtimestamp(ts // 1000000).replace( Out[3]: datetime.datetime(1970, 1, 2, 6, 51, 51, 111111) ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47068 from zhengruifeng/fix_ntz_conversion. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TimestampNTZType.fromInternalnot use the deprecated methodsWhy are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
No