Skip to content

[SPARK-5816] Add huge compatibility warning in DriverWrapper #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

The stability of the new submission gateway assumes that the arguments in DriverWrapper are consistent across multiple Spark versions. However, this is not at all clear from the code itself. In fact, this was broken in 20a6013, which is fortunately OK because both that commit and the original commit that added this gateway are part of the same release.

To prevent this from happening again we should at the very least add a huge warning where appropriate.

@SparkQA
Copy link

SparkQA commented Feb 19, 2015

Test build #27705 has started for PR 4687 at commit 7989b56.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 19, 2015

Test build #27705 has finished for PR 4687 at commit 7989b56.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class JavaFPGrowthExample
    • public class JavaPowerIterationClusteringExample
    • class Partitioner(object):
    • class SparkJobInfo(namedtuple("SparkJobInfo", "jobId stageIds status")):
    • class SparkStageInfo(namedtuple("SparkStageInfo",
    • class StatusTracker(object):

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27705/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 19, 2015
The stability of the new submission gateway assumes that the arguments in `DriverWrapper` are consistent across multiple Spark versions. However, this is not at all clear from the code itself. In fact, this was broken in 20a6013, which is fortunately OK because both that commit and the original commit that added this gateway are part of the same release.

To prevent this from happening again we should at the very least add a huge warning where appropriate.

Author: Andrew Or <andrew@databricks.com>

Closes #4687 from andrewor14/driver-wrapper-warning and squashes the following commits:

7989b56 [Andrew Or] Add huge compatibility warning

(cherry picked from commit 38e624a)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 38e624a Feb 19, 2015
@andrewor14 andrewor14 deleted the driver-wrapper-warning branch February 19, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants