Skip to content

SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2 #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2 #4653

wants to merge 2 commits into from

Conversation

jacek-lewandowski
Copy link
Contributor

No description provided.

@jacek-lewandowski jacek-lewandowski mentioned this pull request Feb 17, 2015
Closed
@SparkQA
Copy link

SparkQA commented Feb 17, 2015

Test build #27636 has started for PR 4653 at commit 843eafb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 17, 2015

Test build #27636 has finished for PR 4653 at commit 843eafb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27636/
Test FAILed.

@pwendell
Copy link
Contributor

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Feb 17, 2015

Test build #27660 has started for PR 4653 at commit 843eafb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27660 has finished for PR 4653 at commit 843eafb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27660/
Test PASSed.

andrewor14
andrewor14 reviewed Feb 18, 2015
View reviewed changes
core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala
slaveTracker.trackerActor = Await.result(selection.resolveOne(timeout * 2), timeout)
val result = Try(Await.result(selection.resolveOne(timeout * 2), timeout))

assert(result.isFailure === true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just do assert(result.isFailure)

@SparkQA
Copy link

SparkQA commented Feb 19, 2015

Test build #27707 has started for PR 4653 at commit 0e199b6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 19, 2015

Test build #27707 has finished for PR 4653 at commit 0e199b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27707/
Test PASSed.

@andrewor14
Copy link
Contributor

Okay I will pull this into master and 1.3. Hopefully there won't be a need for attempt 3. :)

asfgit pushed a commit that referenced this pull request Feb 19, 2015
@jacek-lewandowski
SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2
fbcb949 
Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes #4653 from jacek-lewandowski/SPARK-5548-2-master and squashes the following commits:

0e199b6 [Jacek Lewandowski] SPARK-5548: applied reviewer's comments
843eafb [Jacek Lewandowski] SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2

(cherry picked from commit fb87f44)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in fb87f44 Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacek-lewandowski @SparkQA @AmplabJenkins @pwendell @andrewor14