[SPARK-48121][K8S] Promote KubernetesDriverConf to DeveloperApi
#46373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
May 3, 2024
|
One more thing. If you have some time, please review the following PR on |
jiangzho
changed the title
KubernetesDriverConf to DeveloperApiKubernetesDriverConf to DeveloperApi
dongjoon-hyun
changed the title
KubernetesDriverConf to DeveloperApiKubernetesDriverConf to DeveloperApi
| @@ -78,7 +79,16 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) { | |||
| def getOption(key: String): Option[String] = sparkConf.getOption(key) | |||
| } | |||
|
|
|||
| private[spark] class KubernetesDriverConf( | |||
|
|
|||
There was a problem hiding this comment.
Please remove this redundant empty line addition.
| */ | ||
| @Unstable | ||
| @DeveloperApi | ||
| @Since("4.0.0") |
There was a problem hiding this comment.
Ya, I hope we can make it stable from 4.0.0.
|
Merged to master for Apache Spark 4.0.0-preview. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR aims to promote `KubernetesDriverConf` to `DeveloperApi` ### Why are the changes needed? Since Apache Spark Kubernetes Operator requires this, we had better maintain it as a developer API officially from Apache Spark 4.0.0. apache/spark-kubernetes-operator#10 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the CIs ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46373 from jiangzho/driver_conf. Authored-by: zhou-jiang <zhou_jiang@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
### What changes were proposed in this pull request? This PR aims to promote `KubernetesDriverConf` to `DeveloperApi` ### Why are the changes needed? Since Apache Spark Kubernetes Operator requires this, we had better maintain it as a developer API officially from Apache Spark 4.0.0. apache/spark-kubernetes-operator#10 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the CIs ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46373 from jiangzho/driver_conf. Authored-by: zhou-jiang <zhou_jiang@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to promote
KubernetesDriverConftoDeveloperApiWhy are the changes needed?
Since Apache Spark Kubernetes Operator requires this, we had better maintain it as a developer API officially from Apache Spark 4.0.0.
apache/spark-kubernetes-operator#10
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the CIs
Was this patch authored or co-authored using generative AI tooling?
No