Skip to content

[SPARK-5840][SQL] HiveContext cannot be serialized due to tuple extraction #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-5840][SQL] HiveContext cannot be serialized due to tuple extraction #4628

wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Feb 16, 2015

Also added test cases for checking the serializability of HiveContext and SQLContext.

@SparkQA
Copy link

SparkQA commented Feb 16, 2015

Test build #27564 has started for PR 4628 at commit 8f7dfe8.

  • This patch merges cleanly.

marmbrus
marmbrus reviewed Feb 16, 2015
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
@transient protected[hive] lazy val hiveconf: HiveConf = {
setConf(sessionState.getConf.getAllProperties)
if (sessionState.out == null) {
sessionState.out = new PrintStream(outputBuffer, true, "UTF-8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here and not with the initialization of session state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@SparkQA
Copy link

SparkQA commented Feb 16, 2015

Test build #27564 has finished for PR 4628 at commit 8f7dfe8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27564/
Test PASSed.

@rxin
Copy link
Contributor Author

rxin commented Feb 18, 2015

@marmbrus I updated it with test cases.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27676 has started for PR 4628 at commit ecb3bcd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27676 has finished for PR 4628 at commit ecb3bcd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27676/
Test PASSed.

@marmbrus
Copy link
Contributor

Merged to master and 1.3. Thanks for adding the tests too!

asfgit pushed a commit that referenced this pull request Feb 18, 2015
@rxin @marmbrus
[SPARK-5840][SQL] HiveContext cannot be serialized due to tuple extra…
b86e44c 
…ction

Also added test cases for checking the serializability of HiveContext and SQLContext.

Author: Reynold Xin <rxin@databricks.com>

Closes #4628 from rxin/SPARK-5840 and squashes the following commits:

ecb3bcd [Reynold Xin] test cases and reviews.
55eb822 [Reynold Xin] [SPARK-5840][SQL] HiveContext cannot be serialized due to tuple extraction.

(cherry picked from commit f0e3b71)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in f0e3b71 Feb 18, 2015
@rxin rxin deleted the SPARK-5840 branch February 18, 2015 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rxin @SparkQA @AmplabJenkins @marmbrus