[SPARK-46122][SQL] Set spark.sql.legacy.createHiveTableByDefault to false by default
#46207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
spark.sql.legacy.createHiveTableByDefault by default
dongjoon-hyun
changed the title
spark.sql.legacy.createHiveTableByDefault by defaultspark.sql.legacy.createHiveTableByDefault to false by default
dongjoon-hyun
force-pushed
the
SPARK-46122
branch
from
a625607 to
f20d414
Compare
dongjoon-hyun
force-pushed
the
SPARK-46122
branch
from
0e02a29 to
29d1be5
Compare
|
Thank you, @yaooqinn . I'll throw a discussion thread for this Tonight. |
cloud-fan
approved these changes
Apr 25, 2024
LuciferYang
approved these changes
Apr 26, 2024
ulysses-you
approved these changes
Apr 26, 2024
|
I started a vote for this PR too. |
HyukjinKwon
approved these changes
Apr 28, 2024
|
Hi, @cloud-fan , @yaooqinn , @ulysses-you . If you don't mind, could you participate the vote? :) |
|
Thank you all. Votes passed. |
|
Merged to master for Apache Spark 4.0.0. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
… `false` by default ### What changes were proposed in this pull request? This PR aims to switch `spark.sql.legacy.createHiveTableByDefault` to `false` by default in order to move away from this legacy behavior from `Apache Spark 4.0.0` while the legacy functionality will be preserved during Apache Spark 4.x period by setting `spark.sql.legacy.createHiveTableByDefault=true`. ### Why are the changes needed? Historically, this behavior change was merged at `Apache Spark 3.0.0` activity in SPARK-30098 and reverted officially during the `3.0.0 RC` period. - 2019-12-06: apache#26736 (58be82a) - 2019-12-06: https://lists.apache.org/thread/g90dz1og1zt4rr5h091rn1zqo50y759j - 2020-05-16: apache#28517 At `Apache Spark 3.1.0`, we had another discussion and defined it as `Legacy` behavior via a new configuration by reusing the JIRA ID, SPARK-30098. - 2020-12-01: https://lists.apache.org/thread/8c8k1jk61pzlcosz3mxo4rkj5l23r204 - 2020-12-03: apache#30554 Last year, this was proposed again twice and `Apache Spark 4.0.0` is a good time to make a decision for Apache Spark future direction. - SPARK-42603 on 2023-02-27 as an independent idea. - SPARK-46122 on 2023-11-27 as a part of Apache Spark 4.0.0 idea ### Does this PR introduce _any_ user-facing change? Yes, the migration document is updated. ### How was this patch tested? Pass the CIs with the adjusted test cases. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46207 from dongjoon-hyun/SPARK-46122. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to switch
spark.sql.legacy.createHiveTableByDefaulttofalseby default in order to move away from this legacy behavior fromApache Spark 4.0.0while the legacy functionality will be preserved during Apache Spark 4.x period by settingspark.sql.legacy.createHiveTableByDefault=true.Why are the changes needed?
Historically, this behavior change was merged at
Apache Spark 3.0.0activity in SPARK-30098 and reverted officially during the3.0.0 RCperiod.At
Apache Spark 3.1.0, we had another discussion and defined it asLegacybehavior via a new configuration by reusing the JIRA ID, SPARK-30098.Last year, this was proposed again twice and
Apache Spark 4.0.0is a good time to make a decision for Apache Spark future direction.Does this PR introduce any user-facing change?
Yes, the migration document is updated.
How was this patch tested?
Pass the CIs with the adjusted test cases.
Was this patch authored or co-authored using generative AI tooling?
No.