Skip to content

[MLLIB][SPARK-5502] User guide for isotonic regression #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[MLLIB][SPARK-5502] User guide for isotonic regression #4536

wants to merge 4 commits into from

Conversation

zapletal-martin
Copy link
Contributor

User guide for isotonic regression added to docs/mllib-regression.md including code examples for Scala and Java.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27297 has started for PR 4536 at commit 94cdffb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27298 has started for PR 4536 at commit ad98881.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27299 has started for PR 4536 at commit 504b5c3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27300 has started for PR 4536 at commit 7d8136e.

  • This patch merges cleanly.

@zapletal-martin
Copy link
Contributor Author

https://issues.apache.org/jira/browse/SPARK-5502 mentions the guide should be in docs/mllib-regression.md. I had to create the file. Don't we want to use existing mllib-classification-regression.md instead?

@mengxr
Copy link
Contributor

mengxr commented Feb 11, 2015

@zapletal-martin My bad. It should be mllib-classification-regression.md.

mengxr
mengxr reviewed Feb 11, 2015
View reviewed changes
data/mllib/sample_isotonic_regression_data.csv
@@ -0,0 +1,101 @@
4710.28,500.00,1.00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make the data in range [0, 1](to simulate predictions from logistic regression)? If the weights are always 1.0, we can remove it from the sample data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we can use .txt instead of .csv to be consistent with other files in the same folder.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27297 has finished for PR 4536 at commit 94cdffb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27297/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27298 has finished for PR 4536 at commit ad98881.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27298/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27300 has finished for PR 4536 at commit 7d8136e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27300/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27299 has finished for PR 4536 at commit 504b5c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27299/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 12, 2015

Test build #27352 has started for PR 4536 at commit 80bd4c3.

  • This patch merges cleanly.

@zapletal-martin
SPARK-5502 reworded model prediction rules to use more general langua…
67fe773 
…ge rather than the code/implementation specific terms
@SparkQA
Copy link

SparkQA commented Feb 12, 2015

Test build #27354 has started for PR 4536 at commit 67fe773.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 12, 2015

Test build #27352 has finished for PR 4536 at commit 80bd4c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27352/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 12, 2015

Test build #27354 has finished for PR 4536 at commit 67fe773.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27354/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Feb 13, 2015

@zapletal-martin Could you merge the user guide to mllib-classification-regression.md?

@zapletal-martin
Copy link
Contributor Author

@mengxr can you please expand on that? I am not sure I understand your request.

Isotonic regression belongs to regression category. Documentation for that category is in mllib-classification-regression.md. It however only contains links to other documentation pages and no user guides. The existing links lead to linear models, decision trees and naive bayes. Isotonic regression does not fit into any of those which is the reason why I created a new page.

@mengxr
Copy link
Contributor

mengxr commented Feb 15, 2015

@zapletal-martin You are right. Let's keep the current layout.

asfgit pushed a commit that referenced this pull request Feb 15, 2015
@zapletal-martin @mengxr
[MLLIB][SPARK-5502] User guide for isotonic regression
d96e188 
User guide for isotonic regression added to docs/mllib-regression.md including code examples for Scala and Java.

Author: martinzapletal <zapletal-martin@email.cz>

Closes #4536 from zapletal-martin/SPARK-5502 and squashes the following commits:

67fe773 [martinzapletal] SPARK-5502 reworded model prediction rules to use more general language rather than the code/implementation specific terms
80bd4c3 [martinzapletal] SPARK-5502 created docs page for isotonic regression, added links to the page, updated data and examples
7d8136e [martinzapletal] SPARK-5502 Added documentation for Isotonic regression including examples for Scala and Java
504b5c3 [martinzapletal] SPARK-5502 Added documentation for Isotonic regression including examples for Scala and Java

(cherry picked from commit 61eb126)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 61eb126 Feb 15, 2015
@mengxr
Copy link
Contributor

mengxr commented Feb 15, 2015

LGTM. Merged into master and branch-1.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zapletal-martin @SparkQA @mengxr @AmplabJenkins