Skip to content

[IDE] cannot import src/main/scala & src/test/scala into eclipse as sour... #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ligangty
Copy link
Contributor

...ce folder

When import the whole project into eclipse as maven project, found that the
src/main/scala & src/test/scala can not be set as source folder as default
behavior, so add a "add-source" goal in scala-maven-plugin to let this work.

…ource folder

   When import the whole project into eclipse as maven project, found that the
   src/main/scala & src/test/scala can not be set as source folder as default
   behavior, so add a "add-source" goal in scala-maven-plugin to let this work.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Feb 11, 2015

Hm, I wonder why? src/main/scala and src/test/scala should be the default locations picked up by the Maven compiler / scala plugins. You shouldn't have to configure anything else. Has anyone else reported this behavior? I'd be surprised if Eclipse has a particular problem since IJ (and Maven) don't.

@ligangty
Copy link
Contributor Author

I'm not sure why it has this behavior, but the eclipse surely act as that. I've tested in Eclipse 3.8 and 4.3 with scala-plugin and scala-maven-plugin in both linux and windows platform, and got the same results. And after add this add-source goal, the src/main/scala will be imported as source folder which is reasonable.

@srowen
Copy link
Member

srowen commented Feb 12, 2015

Can anyone else using Eclipse comment? I know people have been using Spark in Eclipse successfully already.

@srowen
Copy link
Member

srowen commented Feb 12, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Feb 12, 2015

Test build #27396 has started for PR 4531 at commit 4e4db4c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 13, 2015

Test build #27396 has finished for PR 4531 at commit 4e4db4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27396/
Test PASSed.

@srowen
Copy link
Member

srowen commented Feb 13, 2015

OK. Can't really hurt as the effect should just be to establish src/main/scala as a source root, which it already should be. This is small, but could you make a quick JIRA for this one and update the title with SPARK-xxxx [BUILD] ...?

asfgit pushed a commit that referenced this pull request Feb 14, 2015
… eclipse as source folder

   When import the whole project into eclipse as maven project, found that the
   src/main/scala & src/test/scala can not be set as source folder as default
   behavior, so add a "add-source" goal in scala-maven-plugin to let this work.

Author: gli <gli@redhat.com>

Closes #4531 from ligangty/addsource and squashes the following commits:

4e4db4c [gli] [IDE] cannot import src/main/scala & src/test/scala into eclipse as source folder

(cherry picked from commit ed5f4bb)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in ed5f4bb Feb 14, 2015
@ligangty ligangty deleted the addsource branch June 17, 2015 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants