[SPARK-47187][SQL][3.4] Fix hive compress output config does not work #45286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
approved these changes
Feb 28, 2024
ulysses-you
added a commit
that referenced
this pull request
Feb 28, 2024
### What changes were proposed in this pull request? This pr fixs the issue that `setupHadoopConfForCompression` did not set isCompressed as expected due to we implicitly convert ShimFileSinkDesc to FileSinkDesc. This issue does not affect master branch since we removed ShimFileSinkDesc in #40848 ### Why are the changes needed? To make `hive.exec.compress.output` work as expected. ### Does this PR introduce _any_ user-facing change? yes, fix bug ### How was this patch tested? manually test ### Was this patch authored or co-authored using generative AI tooling? no Closes #45286 from ulysses-you/fix. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
|
thanks, merging to branch-3.4 |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
### What changes were proposed in this pull request? This pr fixs the issue that `setupHadoopConfForCompression` did not set isCompressed as expected due to we implicitly convert ShimFileSinkDesc to FileSinkDesc. This issue does not affect master branch since we removed ShimFileSinkDesc in apache#40848 ### Why are the changes needed? To make `hive.exec.compress.output` work as expected. ### Does this PR introduce _any_ user-facing change? yes, fix bug ### How was this patch tested? manually test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45286 from ulysses-you/fix. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fixs the issue that
setupHadoopConfForCompressiondid not set isCompressed as expected due to we implicitly convert ShimFileSinkDesc to FileSinkDesc. This issue does not affect master branch since we removed ShimFileSinkDesc in #40848Why are the changes needed?
To make
hive.exec.compress.outputwork as expected.Does this PR introduce any user-facing change?
yes, fix bug
How was this patch tested?
manually test
Was this patch authored or co-authored using generative AI tooling?
no