Skip to content

[SPARK-46945][K8S] Add spark.kubernetes.legacy.useReadWriteOnceAccessMode for old K8s clusters#44985

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46945
Closed

[SPARK-46945][K8S] Add spark.kubernetes.legacy.useReadWriteOnceAccessMode for old K8s clusters#44985
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-46945

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 1, 2024

What changes were proposed in this pull request?

This PR aims to introduce a legacy configuration for K8s PVC access mode to mitigate migrations issues in old K8s clusters.

Why are the changes needed?

  • The default value of spark.kubernetes.legacy.useReadWriteOnceAccessMode is false in Apache Spark 4.
  • To help the users who cannot upgrade their K8s versions.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Hi, @yaooqinn . Could you review this, please?

The recent Apache Spark 3.5.1 release discussion in dev mailing list reminds me your error reporting. I added this legacy configuration with different default values.

  • false in master
  • true in branch-3.5 and branch-3.4.

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool to have it.

@pan3793
Copy link
Member

pan3793 commented Feb 2, 2024

... in old K8s clusters

I suppose the "old" means K8s version < 1.22? would be helpful to mention it in the PR description or configuration docs.

@yaooqinn yaooqinn closed this in 457f6f5 Feb 2, 2024
@yaooqinn
Copy link
Member

yaooqinn commented Feb 2, 2024

Thanks @dongjoon-hyun @pan3793

Merged to master.

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn and @pan3793 .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-46945 branch February 2, 2024 02:44
yaooqinn pushed a commit that referenced this pull request Feb 2, 2024
…AccessMode` for old K8s clusters

### What changes were proposed in this pull request?

This PR aims to introduce a legacy configuration for K8s PVC access mode to mitigate migrations issues in old K8s clusters.

This is a kind of backport of
- #44985

### Why are the changes needed?

- The default value of `spark.kubernetes.legacy.useReadWriteOnceAccessMode` is `true` in branch-3.5.
- To help the users who cannot upgrade their K8s versions.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44986 from dongjoon-hyun/SPARK-46945-3.5.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Kent Yao <yao@apache.org>
yaooqinn pushed a commit that referenced this pull request Feb 2, 2024
…AccessMode` for old K8s clusters

### What changes were proposed in this pull request?

This PR aims to introduce a legacy configuration for K8s PVC access mode to mitigate migrations issues in old K8s clusters.

This is a kind of backport of
- #44985

### Why are the changes needed?

- The default value of `spark.kubernetes.legacy.useReadWriteOnceAccessMode` is `true` in branch-3.4.
- To help the users who cannot upgrade their K8s versions.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44987 from dongjoon-hyun/SPARK-46945-3.4.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Kent Yao <yao@apache.org>
@dongjoon-hyun
Copy link
Member Author

Hi, @pan3793 . Apache Spark 4.0 only supports K8s 1.26+ already via SPARK-44119

I suppose the "old" means K8s version < 1.22? would be helpful to mention it in the PR description or configuration docs.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Feb 2, 2024

I believe the user will know the capability at the first Spark 4.0 run if their cluster is not ready for ReadWriterOncePod. When Apache Spark 4.0.0 comes, I expect K8s v1.27+ mostly because of the following end of support plan in the public cloud.

K8s AKS GKE EKS
1.26 2024-03 2024-06 2024-06

@pan3793
Copy link
Member

pan3793 commented Feb 2, 2024

I believe the user will know the capability at the first Spark 4.0 run if their cluster is not ready for ReadWriterOncePod.

That makes sense, thanks for the explanation.

szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
…AccessMode` for old K8s clusters

This PR aims to introduce a legacy configuration for K8s PVC access mode to mitigate migrations issues in old K8s clusters.

This is a kind of backport of
- apache#44985

- The default value of `spark.kubernetes.legacy.useReadWriteOnceAccessMode` is `true` in branch-3.4.
- To help the users who cannot upgrade their K8s versions.

No.

Manually.

No.

Closes apache#44987 from dongjoon-hyun/SPARK-46945-3.4.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants