[SPARK-46870][CORE] Support Spark Master Log UI #44890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this too, @yaooqinn ? |
yaooqinn
reviewed
Jan 26, 2024
| private[ui] class LogPage(parent: MasterWebUI) extends WebUIPage("logPage") with Logging { | ||
| private val defaultBytes = 100 * 1024 | ||
|
|
||
| def renderLog(request: HttpServletRequest): String = { |
There was a problem hiding this comment.
Ah, right. Thanks. I didn't include /log at MasterWebUI because Master needs no proxy unlike Worker, but I missed this part. Let me remove this.
|
Thank you, @yaooqinn . Now, it's much simplied. |
|
Thank you, @yaooqinn . Merged to master. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
### What changes were proposed in this pull request? This PR aims to support `Spark Master` Log UI. ### Why are the changes needed? This is a new feature to allow the users to access the master log like the following. The value of `Status`, e.g., `ALIVE`, has a new link for log UI. **BEFORE**  **AFTER**   ### Does this PR introduce _any_ user-facing change? No. This is a new link and UI. ### How was this patch tested? Manually. ``` $ sbin/start-master.sh ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#44890 from dongjoon-hyun/SPARK-46870. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Aug 26, 2024
### What changes were proposed in this pull request? This PR aims to remove `SPARK_NO_DAEMONIZE` in favor of live log UIs. - apache/spark#44890 - apache/spark#44888 ### Why are the changes needed? Spark Master/Worker supports live log UIs already. A user doesn't need to use `kubectl` to access K8s log. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #103 from dongjoon-hyun/SPARK-49388. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
Spark MasterLog UI.Why are the changes needed?
This is a new feature to allow the users to access the master log like the following. The value of
Status, e.g.,ALIVE, has a new link for log UI.BEFORE
AFTER
Does this PR introduce any user-facing change?
No. This is a new link and UI.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?
No