Skip to content

Conversation

@HyukjinKwon
Copy link
Member

This PR cherry-picks #43855 to branch-3.5


What changes were proposed in this pull request?

This PR restores the DSv2 documentation. #38392 mistakenly added org/apache/spark/sql/connect as a private that includes org/apache/spark/sql/connector.

Why are the changes needed?

For end users to read DSv2 documentation.

Does this PR introduce any user-facing change?

Yes, it restores the DSv2 API documentation that used to be there https://spark.apache.org/docs/3.3.0/api/scala/org/apache/spark/sql/connector/catalog/index.html

How was this patch tested?

Manually tested via:

SKIP_PYTHONDOC=1 SKIP_RDOC=1 SKIP_SQLDOC=1 bundle exec jekyll build

Was this patch authored or co-authored using generative AI tooling?

No.

This PR restores the DSv2 documentation. apache#38392 mistakenly added `org/apache/spark/sql/connect` as a private that includes `org/apache/spark/sql/connector`.

For end users to read DSv2 documentation.

Yes, it restores the DSv2 API documentation that used to be there https://spark.apache.org/docs/3.3.0/api/scala/org/apache/spark/sql/connector/catalog/index.html

Manually tested via:

```
SKIP_PYTHONDOC=1 SKIP_RDOC=1 SKIP_SQLDOC=1 bundle exec jekyll build
```

No.

Closes apache#43855 from HyukjinKwon/connector-docs.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit a7147c8)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dongjoon-hyun pushed a commit that referenced this pull request Nov 17, 2023
This PR cherry-picks #43855 to branch-3.5

---

### What changes were proposed in this pull request?

This PR restores the DSv2 documentation. #38392 mistakenly added `org/apache/spark/sql/connect` as a private that includes `org/apache/spark/sql/connector`.

### Why are the changes needed?

For end users to read DSv2 documentation.

### Does this PR introduce _any_ user-facing change?

Yes, it restores the DSv2 API documentation that used to be there https://spark.apache.org/docs/3.3.0/api/scala/org/apache/spark/sql/connector/catalog/index.html

### How was this patch tested?

Manually tested via:

```
SKIP_PYTHONDOC=1 SKIP_RDOC=1 SKIP_SQLDOC=1 bundle exec jekyll build
```

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #43865 from HyukjinKwon/SPARK-45963-3.5.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

Merged to branch-3.5.

@HyukjinKwon HyukjinKwon deleted the SPARK-45963-3.5 branch January 15, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants