[SPARK-45651][BUILD] Publish snapshot manually #43512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have outlined a sequence of steps to fix the snapshot publish workflow in SPARK-45651. This is a pre-cursor, which can remain in master as it is generally useful if publishing snapshots fail and a workflow fix is required, which is where merely rerunning does not work (as the rerun will not pick up the workflow fix). @LuciferYang @HyukjinKwon |
This was referenced Oct 24, 2023
HyukjinKwon
approved these changes
Oct 24, 2023
HyukjinKwon
changed the title
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 26, 2023
### What changes were proposed in this pull request? This logs memory consumption while publishing snapshots. This is to investigate whether the suspected high memory usage is the root cause of `publish_snapshots` failures for master. Merging this after #43512 allows to run this manually. ### Why are the changes needed? The working assumption is that high memory usage is the root cause. This logging should provide proof or disproof for this assumption. This can be reverted once more is known or SPARK-45651 is fixed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Locally ### Was this patch authored or co-authored using generative AI tooling? No Closes #43513 from EnricoMi/publish-snapshot-log-memory. Authored-by: Enrico Minack <github@enrico.minack.dev> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With a manual trigger, the workflow can be executed manually after merging a fix of the workflow to master. This also allows to run the workflow only on a subset of branches (e.g. those that failed).
Why are the changes needed?
Sometime, publishing snapshots fails. If a fix of the workflow file is needed, that change can only be tested by waiting for the next day when the cron even triggers the next publish. This is quite a long turnaround to test fixes to that workflow (see #43364).
Does this PR introduce any user-facing change?
No, this is purely build CI related.
How was this patch tested?
This can only be tested in master. Github workflow syntax tested in a private repo.
Was this patch authored or co-authored using generative AI tooling?
No