[MINOR][SQL] Remove signature from Hive thriftserver exception #43402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 17, 2023
### What changes were proposed in this pull request? Don't return expected signature to caller in Hive thriftserver exception ### Why are the changes needed? Please see private discussion ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #43402 from srowen/HiveCookieSigner. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit cf59b1f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 17, 2023
### What changes were proposed in this pull request? Don't return expected signature to caller in Hive thriftserver exception ### Why are the changes needed? Please see private discussion ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #43402 from srowen/HiveCookieSigner. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit cf59b1f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 17, 2023
### What changes were proposed in this pull request? Don't return expected signature to caller in Hive thriftserver exception ### Why are the changes needed? Please see private discussion ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #43402 from srowen/HiveCookieSigner. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit cf59b1f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Merged to master/3.5/3.4/3.3. |
beliefer
reviewed
Oct 18, 2023
| if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) { | ||
| throw new IllegalArgumentException("Invalid sign, original = " + originalSignature + | ||
| " current = " + currentSignature); | ||
| throw new IllegalArgumentException("Invalid sign"); |
Contributor
There was a problem hiding this comment.
Could we add incorrect signature? Invalid sign makes confusion.
Member
Author
There was a problem hiding this comment.
I went for minimal change here. This is copied from Hive and meant to be a stopgap until Hive addresses an ongoing discussion about a potential security issue here
Contributor
|
late LGTM, hahaha, this is a very old security issue. |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
### What changes were proposed in this pull request? Don't return expected signature to caller in Hive thriftserver exception ### Why are the changes needed? Please see private discussion ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#43402 from srowen/HiveCookieSigner. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit cf59b1f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 31, 2025
### What changes were proposed in this pull request? This PR aims to remove signature from Hive thriftserver DEBUG log. ### Why are the changes needed? This is aligned with the upstream Apache Hive project. - apache/hive#4887 This is also aligned with the previous Spark change. - #43402 ### Does this PR introduce _any_ user-facing change? No, this is a debug message removal. ### How was this patch tested? Pass the CIs and manual review (because this is a removal). ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49752 from dongjoon-hyun/minor_debug_msg. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 31, 2025
### What changes were proposed in this pull request? This PR aims to remove signature from Hive thriftserver DEBUG log. ### Why are the changes needed? This is aligned with the upstream Apache Hive project. - apache/hive#4887 This is also aligned with the previous Spark change. - #43402 ### Does this PR introduce _any_ user-facing change? No, this is a debug message removal. ### How was this patch tested? Pass the CIs and manual review (because this is a removal). ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49752 from dongjoon-hyun/minor_debug_msg. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4a33e96) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…e#676) ### What changes were proposed in this pull request? Don't return expected signature to caller in Hive thriftserver exception ### Why are the changes needed? Please see private discussion ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#43402 from srowen/HiveCookieSigner. Authored-by: Sean Owen <srowen@gmail.com> (cherry picked from commit cf59b1f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com> Co-authored-by: Sean Owen <srowen@gmail.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? This PR aims to remove signature from Hive thriftserver DEBUG log. ### Why are the changes needed? This is aligned with the upstream Apache Hive project. - apache/hive#4887 This is also aligned with the previous Spark change. - apache#43402 ### Does this PR introduce _any_ user-facing change? No, this is a debug message removal. ### How was this patch tested? Pass the CIs and manual review (because this is a removal). ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49752 from dongjoon-hyun/minor_debug_msg. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 04e0ddf) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't return expected signature to caller in Hive thriftserver exception
Why are the changes needed?
Please see private@ discussion
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No