[SPARK-45442][PYTHON][DOCS] Refine docstring of DataFrame.show #43252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
reviewed
Oct 7, 2023
python/pyspark/sql/dataframe.py
Outdated
Contributor
There was a problem hiding this comment.
I checked all the other cases.
Shall we change to default 20. Number of rows to show. ?
Contributor
Author
There was a problem hiding this comment.
Hmm I didn't get the point. Do you mean changing Default is 20 to Default: 20 rows to show since the truncation is also 20 characters?
Contributor
There was a problem hiding this comment.
Number of rows to show to default 20. Number of rows to show.
python/pyspark/sql/dataframe.py
Outdated
beliefer
reviewed
Oct 10, 2023
Contributor
beliefer
left a comment
beliefer
left a comment
There was a problem hiding this comment.
LGTM. cc @HyukjinKwon @zhengruifeng
HyukjinKwon
approved these changes
Oct 10, 2023
Member
|
@allisonwang-db mind rebasing |
allisonwang-db
force-pushed
the
spark-45442-refine-show
branch
from
d5c7aeb to
9ff89b8
Compare
zhengruifeng
approved these changes
Oct 12, 2023
Contributor
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refines the docstring of
DataFrame.showby adding more examples.Why are the changes needed?
To improve PySpark documentations.
Does this PR introduce any user-facing change?
No
How was this patch tested?
doctest
Was this patch authored or co-authored using generative AI tooling?
No