[SPARK-45418][SQL][PYTHON][CONNECT] Change current_database() column alias to current_schema() #43235
Conversation
michaelzhan-db
force-pushed
the
SPARK-45418
branch
from
4e3f072 to
35e9b77
Compare
| override def dataType: DataType = StringType | ||
| override def nullable: Boolean = false | ||
| override def prettyName: String = "current_database" | ||
| override def prettyName: String = "current_schema" |
There was a problem hiding this comment.
If we change current_database to current_schema, we should rename CurrentDatabase to CurrentSchema.
How about using current_database as a unified name?
There was a problem hiding this comment.
There was a problem hiding this comment.
CurrentDatabase was there since 1.6.0 and seems safer to not rename it now. The expression class name is not user-facing anyway.
There was a problem hiding this comment.
AFAIK schema is a more standard name to reference to a namespace that keeps database objects.
There was a problem hiding this comment.
So, how about using current_database as a unified name? it is consistent with class name.
There was a problem hiding this comment.
Sorry I'm a bit confused. This PR tries to use the name schema more widely as it's more SQL standard. Are you saying no to this PR and want to stick with database?
There was a problem hiding this comment.
I know this PR want to use the name schema here, it's okay. However, it caused inconsistent between the class name of the CurrentDatabase and its prettyName. Is this a problem? If not, then it's okay.
There was a problem hiding this comment.
It's fine, TruncTimestamp overrides prettyName as date_trunc
|
also cc @cloud-fan @peter-toth |
beliefer
changed the title
|
thanks, merging to master! |
4 participants
What changes were proposed in this pull request?
Change column alias for current_database() to current_schema.
Why are the changes needed?
To better align with preferred usage of schema rather than database for three part namespace.
Does this PR introduce any user-facing change?
Yes,
current_database()column alias is nowcurrent_schema().How was this patch tested?
Unit tests pass.
Was this patch authored or co-authored using generative AI tooling?
No.