-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-44782][INFRA] Adjust PR template to Generative Tooling Guidance recommendations #42469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e recommendations
|
cc @zhengruifeng FYI |
|
I guess this should be documented in https://spark.apache.org/developer-tools.html instead of PR template? |
|
It should be in both places. It's interesting. The typical CONTRIBUTING.md text that we have says, "When you contribute code, you affirm that the contribution is your original work", which seems at odds with the ASF guidance. I assume we are counting AI-assisted code as original work. |
@zhengruifeng As per linked document:
So, as I read this, it is recommended, although not required, to keep it in the commit message. If so, and we follow the advice, PR template is the place to put it. |
@srowen I am not a lawyer, so please take whatever I say with a grain of salt. The current interpretation seems to be that the generated content is not considered to be work within the meaning of the copyright law. So "work" in this meaning is only what a human does with the output. This position seems to be echoed by the ASF policy and the U.S. Copyright guidance it links to. It is also consistent with the informal opinions I got from the Polish Patent Office. How we are supposed to judge if a given human contribution is sufficient for inclusion of the patch in the project without weakening ASF copyright claims is a mystery to me. Not to even mention the evaluation of the terms of service of any tool that contributors decide to use. I have a gut feeling that at this point, using generative AI for content creation within a public project is a serious liability with little to gain, but given the lack of response on the dev list, following the ASF recommendations is the least we should do. |
This PR adds notes on generative tooling and link to the relevant ASF policy. As requested in comments to apache/spark#42469 Author: zero323 <mszymkiewicz@gmail.com> Closes #472 from zero323/SPARK-44782-generative-tooling-notes.
|
Merged to master (the failure can't be related) |
…e recommendations ### What changes were proposed in this pull request? This PR adds _Was this patch authored or co-authored using generative AI tooling?_ section to the PR template. ### Why are the changes needed? To reflect recommendations of the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual inspection. Closes apache#42469 from zero323/SPARK-44782. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
What changes were proposed in this pull request?
This PR adds Was this patch authored or co-authored using generative AI tooling? section to the PR template.
Why are the changes needed?
To reflect recommendations of the ASF Generative Tooling Guidance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual inspection.