Skip to content

SPARK-4430 [STREAMING] [TEST] Apache RAT Checks fail spuriously on test files #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Jan 24, 2015

Another trivial one. The RAT failure was due to temp files from FailureSuite not being cleaned up. This just makes the cleanup more reliable by using the standard temp dir mechanism.

@SparkQA
Copy link

SparkQA commented Jan 24, 2015

Test build #26051 has started for PR 4189 at commit 9ea63ff.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 24, 2015

Test build #26051 has finished for PR 4189 at commit 9ea63ff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26051/
Test PASSed.

@andrewor14
Copy link
Contributor

Makes sense. I'm merging this into master 1.2 and 1.1

asfgit pushed a commit that referenced this pull request Jan 26, 2015
…st files

Another trivial one. The RAT failure was due to temp files from `FailureSuite` not being cleaned up. This just makes the cleanup more reliable by using the standard temp dir mechanism.

Author: Sean Owen <sowen@cloudera.com>

Closes #4189 from srowen/SPARK-4430 and squashes the following commits:

9ea63ff [Sean Owen] Properly acquire a temp directory to ensure it is cleaned up at shutdown, which helps avoid a RAT check failure

(cherry picked from commit 0528b85)
Signed-off-by: Andrew Or <andrew@databricks.com>
asfgit pushed a commit that referenced this pull request Jan 26, 2015
…st files

Another trivial one. The RAT failure was due to temp files from `FailureSuite` not being cleaned up. This just makes the cleanup more reliable by using the standard temp dir mechanism.

Author: Sean Owen <sowen@cloudera.com>

Closes #4189 from srowen/SPARK-4430 and squashes the following commits:

9ea63ff [Sean Owen] Properly acquire a temp directory to ensure it is cleaned up at shutdown, which helps avoid a RAT check failure

(cherry picked from commit 0528b85)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 0528b85 Jan 26, 2015
@srowen srowen deleted the SPARK-4430 branch January 26, 2015 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants