[SPARK-44287][SQL] Use PartitionEvaluator API in RowToColumnarExec & ColumnarToRowExec SQL operators. #41839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkc
changed the title
beliefer
reviewed
Jul 4, 2023
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala
Outdated
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_refactorToEvaluatorFactory1
branch
from
a267a1a to
d17712f
Compare
viirya
reviewed
Jul 5, 2023
| } else { | ||
| child.executeColumnar().mapPartitionsInternal { batches => | ||
| val evaluator = evaluatorFactory.createEvaluator() | ||
| evaluator.eval(0, batches) |
There was a problem hiding this comment.
We don't need pass real partition index?
There was a problem hiding this comment.
In the original code, the index was not used as mapPartitionsInternal is called
There was a problem hiding this comment.
This is not right. Even if it's not used for now, we should still set it correctly to be future-proof.
There was a problem hiding this comment.
@cloud-fan , Thanks for the fix,
I can fix similar issue in other merged PR
https://github.com/apache/spark/pull/42024/files
viirya
reviewed
Jul 5, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jul 5, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Jul 5, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarEvaluatorFactory.scala
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_refactorToEvaluatorFactory1
branch
from
d17712f to
2fcb311
Compare
vinodkc
force-pushed
the
br_refactorToEvaluatorFactory1
branch
from
2fcb311 to
8908f9c
Compare
vinodkc
changed the title
cloud-fan
approved these changes
Jul 7, 2023
|
thanks, merging to master! |
cloud-fan
added a commit
that referenced
this pull request
Jul 28, 2023
### What changes were proposed in this pull request? This is a followup of #41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #42185 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
that referenced
this pull request
Jul 28, 2023
### What changes were proposed in this pull request? This is a followup of #41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #42185 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit bf1bbc5) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 31, 2023
### What changes were proposed in this pull request? This is a followup of #41839 , to fix an unintentional change. That PR added an optimization to return an empty iterator directly if the input iterator is empty. However, checking `inputIterator.hasNext` may trigger query execution, which is different than before. It should be completely lazy and wait for the root operator's iterator to trigger the execution. ### Why are the changes needed? fix unintentional change ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #42226 from cloud-fan/fo. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 31, 2023
### What changes were proposed in this pull request? This is a followup of #41839 , to fix an unintentional change. That PR added an optimization to return an empty iterator directly if the input iterator is empty. However, checking `inputIterator.hasNext` may trigger query execution, which is different than before. It should be completely lazy and wait for the root operator's iterator to trigger the execution. ### Why are the changes needed? fix unintentional change ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #42226 from cloud-fan/fo. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 0f9cca5) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…ColumnarToRowExec SQL operators ### What changes were proposed in this pull request? SQL operators `RowToColumnarExec` & `ColumnarToRowExec` are updated to use the `PartitionEvaluator` API to do execution. ### Why are the changes needed? To avoid the use of lambda during distributed execution. Ref: SPARK-43061 for more details. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Updated 2 test cases, once all the SQL operators are migrated, the flag `spark.sql.execution.useTaskEvaluator` will be enabled by default to avoid running the tests with and without this TaskEvaluator Closes apache#41839 from vinodkc/br_refactorToEvaluatorFactory1. Authored-by: Vinod KC <vinod.kc.in@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This is a followup of apache#41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#42185 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This is a followup of apache#41839 , to fix an unintentional change. That PR added an optimization to return an empty iterator directly if the input iterator is empty. However, checking `inputIterator.hasNext` may trigger query execution, which is different than before. It should be completely lazy and wait for the root operator's iterator to trigger the execution. ### Why are the changes needed? fix unintentional change ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#42226 from cloud-fan/fo. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SQL operators
RowToColumnarExec&ColumnarToRowExecare updated to use thePartitionEvaluatorAPI to do execution.Why are the changes needed?
To avoid the use of lambda during distributed execution.
Ref: SPARK-43061 for more details.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated 2 test cases, once all the SQL operators are migrated, the flag
spark.sql.execution.useTaskEvaluatorwill be enabled by default to avoid running the tests with and without this TaskEvaluator