[SPARK-44242] Improve Max Heap not set check #41806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashangit
force-pushed
the
nfraison/SPARK-44242
branch
2 times, most recently
from
e072703 to
30d72e2
Compare
mridulm
reviewed
Jun 30, 2023
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
Outdated
Show resolved
Hide resolved
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
Outdated
Show resolved
Hide resolved
ashangit
force-pushed
the
nfraison/SPARK-44242
branch
3 times, most recently
from
3a19cd3 to
2f2ec2f
Compare
mridulm
approved these changes
Jul 2, 2023
LuciferYang
reviewed
Jul 2, 2023
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
Outdated
Show resolved
Hide resolved
|
@ashangit Java linter check failed, please fix it when you have time |
LuciferYang
reviewed
Jul 3, 2023
| public void testCheckJavaOptionsThrowException() throws Exception { | ||
| Map<String, String> env = new HashMap<>(); | ||
| List<String> sparkSubmitArgs = Arrays.asList( | ||
| parser.MASTER, |
There was a problem hiding this comment.
indentation: should be 2 space too
LuciferYang
reviewed
Jul 3, 2023
| public void testCheckJavaOptions() throws Exception { | ||
| Map<String, String> env = new HashMap<>(); | ||
| List<String> sparkSubmitArgs = Arrays.asList( | ||
| parser.MASTER, |
HyukjinKwon
approved these changes
Jul 3, 2023
|
@ashangit Can you rebase the code or re-trigger GA? Some testing tasks failed |
Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed
ashangit
force-pushed
the
nfraison/SPARK-44242
branch
from
4aeea91 to
644a928
Compare
|
Test seems now stuck on pyspak-sql one: https://github.com/ashangit/spark/actions/runs/5451917791/jobs/9918773466#logs without any logs after 4H |
|
You can try canceling the running GA task and then re-trigger the failed one |
|
@mridulm can we merge this PR? |
|
Ah, I thought @LuciferYang might have merged this one :-) |
|
Merged to master. |
|
Sorry, I forgot about that… |
|
Just kidding @LuciferYang :-) |
hvanhovell
pushed a commit
to hvanhovell/spark
that referenced
this pull request
Aug 13, 2023
### What changes were proposed in this pull request? Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed For Ex. this command failed `./bin/spark-submit --class org.apache.spark.examples.SparkPi --conf "spark.driver.extraJavaOptions=-Dtest=Xmx" examples/jars/spark-examples_2.12-3.4.1.jar 100` ### Why are the changes needed? The command should any failed if the -Xmx argument is set not if it is part of another parameter or string ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unitary test Closes apache#41806 from ashangit/nfraison/SPARK-44242. Authored-by: Nicolas Fraison <nicolas.fraison@datadoghq.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed For Ex. this command failed `./bin/spark-submit --class org.apache.spark.examples.SparkPi --conf "spark.driver.extraJavaOptions=-Dtest=Xmx" examples/jars/spark-examples_2.12-3.4.1.jar 100` ### Why are the changes needed? The command should any failed if the -Xmx argument is set not if it is part of another parameter or string ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unitary test Closes apache#41806 from ashangit/nfraison/SPARK-44242. Authored-by: Nicolas Fraison <nicolas.fraison@datadoghq.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed For Ex. this command failed `./bin/spark-submit --class org.apache.spark.examples.SparkPi --conf "spark.driver.extraJavaOptions=-Dtest=Xmx" examples/jars/spark-examples_2.12-3.4.1.jar 100` ### Why are the changes needed? The command should any failed if the -Xmx argument is set not if it is part of another parameter or string ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unitary test Closes apache#41806 from ashangit/nfraison/SPARK-44242. Authored-by: Nicolas Fraison <nicolas.fraison@datadoghq.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
### What changes were proposed in this pull request? Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed For Ex. this command failed `./bin/spark-submit --class org.apache.spark.examples.SparkPi --conf "spark.driver.extraJavaOptions=-Dtest=Xmx" examples/jars/spark-examples_2.12-3.4.1.jar 100` ### Why are the changes needed? The command should any failed if the -Xmx argument is set not if it is part of another parameter or string ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unitary test Closes apache#41806 from ashangit/nfraison/SPARK-44242. Authored-by: Nicolas Fraison <nicolas.fraison@datadoghq.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com> Co-authored-by: Nicolas Fraison <nicolas.fraison@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently if any Xmx string is available in the driver java options even if not related to Max Heap setting the job sumission failed
For Ex. this command failed
./bin/spark-submit --class org.apache.spark.examples.SparkPi --conf "spark.driver.extraJavaOptions=-Dtest=Xmx" examples/jars/spark-examples_2.12-3.4.1.jar 100Why are the changes needed?
The command should any failed if the -Xmx argument is set not if it is part of another parameter or string
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a unitary test