Skip to content

[SPARK-42478][SQL][3.3] Make a serializable jobTrackerId instead of a non-serializable JobID in FileWriterFactory #40290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yikf
Copy link
Contributor

@yikf yikf commented Mar 6, 2023

This is a backport of #40064 for branch-3.3

What changes were proposed in this pull request?

Make a serializable jobTrackerId instead of a non-serializable JobID in FileWriterFactory

Why are the changes needed?

SPARK-41448 make consistent MR job IDs in FileBatchWriter and FileFormatWriter, but it breaks a serializable issue, JobId is non-serializable.

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA

@github-actions github-actions bot added the SQL label Mar 6, 2023
@yikf
Copy link
Contributor Author

yikf commented Mar 6, 2023

cc @cloud-fan @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dongjoon-hyun pushed a commit that referenced this pull request Mar 6, 2023
… non-serializable JobID in FileWriterFactory

This is a backport of #40064 for branch-3.3

### What changes were proposed in this pull request?

Make a serializable jobTrackerId instead of a non-serializable JobID in FileWriterFactory

### Why are the changes needed?

[SPARK-41448](https://issues.apache.org/jira/browse/SPARK-41448) make consistent MR job IDs in FileBatchWriter and FileFormatWriter, but it breaks a serializable issue, JobId is non-serializable.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

GA

Closes #40290 from Yikf/backport-SPARK-42478-3.3.

Authored-by: Yikf <yikaifei@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Merged to branch-3.3. Thank you, @yikf and @cloud-fan .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants