[SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client #39957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
approved these changes
Feb 9, 2023
Member
|
Connect tests passed. Let me merge this one (so I can update my Pr). Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 9, 2023
…per exception in the Python client ### What changes were proposed in this pull request? Adds details to non-fatal errors to raise a proper exception in the Python client, which makes `df.sample` raise `IllegalArgumentException` as same as PySpark, except for the timing that is delayed to call actions. ### Why are the changes needed? Currently `SparkConnectService` does not add details for `NonFatal` exceptions to the `PRCStatus`, so the Python client can't detect the exception properly and raises `SparkConnectGrpcException` instead. It also should have the details for the Python client. ### Does this PR introduce _any_ user-facing change? Users will see a proper exception when they call `df.sample` with illegal arguments, but in a different timing. ### How was this patch tested? Enabled `DataFrameParityTests.test_sample`. Closes #39957 from ueshin/issues/SPARK-42338/sample. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ced6750) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…per exception in the Python client ### What changes were proposed in this pull request? Adds details to non-fatal errors to raise a proper exception in the Python client, which makes `df.sample` raise `IllegalArgumentException` as same as PySpark, except for the timing that is delayed to call actions. ### Why are the changes needed? Currently `SparkConnectService` does not add details for `NonFatal` exceptions to the `PRCStatus`, so the Python client can't detect the exception properly and raises `SparkConnectGrpcException` instead. It also should have the details for the Python client. ### Does this PR introduce _any_ user-facing change? Users will see a proper exception when they call `df.sample` with illegal arguments, but in a different timing. ### How was this patch tested? Enabled `DataFrameParityTests.test_sample`. Closes apache#39957 from ueshin/issues/SPARK-42338/sample. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ced6750) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds details to non-fatal errors to raise a proper exception in the Python client, which makes
df.sampleraiseIllegalArgumentExceptionas same as PySpark, except for the timing that is delayed to call actions.Why are the changes needed?
Currently
SparkConnectServicedoes not add details forNonFatalexceptions to thePRCStatus, so the Python client can't detect the exception properly and raisesSparkConnectGrpcExceptioninstead.It also should have the details for the Python client.
Does this PR introduce any user-facing change?
Users will see a proper exception when they call
df.samplewith illegal arguments, but in a different timing.How was this patch tested?
Enabled
DataFrameParityTests.test_sample.