[SPARK-42314][SQL] Assign name to _LEGACY_ERROR_TEMP_2127 #39890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @srielau @MaxGekk @cloud-fan Please review this error class ticket when you find some time. |
srielau
approved these changes
Feb 5, 2023
| ], | ||
| "sqlState" : "22012" | ||
| }, | ||
| "DUPLICATED_MAP_KEY" : { |
Contributor
There was a problem hiding this comment.
Is this associated with a function? Can we name it?
Contributor
Author
There was a problem hiding this comment.
I believe it seems not related to specific function, but can't 100% sure since I haven't enough context for Scala-side functions yet.
@MaxGekk Could you have an answer for this, if we name any specific function for this error class?
Member
There was a problem hiding this comment.
This error can occur in multiple functions:
- map_concat
- map_from_entries
- map
- map_from_arrays
- str_to_map
- transform_keys
Contributor
Author
There was a problem hiding this comment.
Yeah, IMHO maybe it is okay to leave it as is, because I believe "DUPLICATED_MAP_KEY" is pretty intuitive when users face this error during use such a map function?
MaxGekk
reviewed
Feb 6, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Show resolved
Hide resolved
MaxGekk
requested changes
Feb 8, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
…xecutionErrors.scala Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
MaxGekk
approved these changes
Feb 8, 2023
Member
MaxGekk
pushed a commit
that referenced
this pull request
Feb 8, 2023
### What changes were proposed in this pull request? This PR proposes to assign name to _LEGACY_ERROR_TEMP_2127, "DUPLICATED_MAP_KEY". ### Why are the changes needed? We should assign proper name to _LEGACY_ERROR_TEMP_* ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*` Closes #39890 from itholic/LEGACY_2127. Lead-authored-by: itholic <haejoon.lee@databricks.com> Co-authored-by: Haejoon Lee <44108233+itholic@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 4b50a46) Signed-off-by: Max Gekk <max.gekk@gmail.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR proposes to assign name to _LEGACY_ERROR_TEMP_2127, "DUPLICATED_MAP_KEY". ### Why are the changes needed? We should assign proper name to _LEGACY_ERROR_TEMP_* ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*` Closes apache#39890 from itholic/LEGACY_2127. Lead-authored-by: itholic <haejoon.lee@databricks.com> Co-authored-by: Haejoon Lee <44108233+itholic@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 4b50a46) Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_2127, "DUPLICATED_MAP_KEY".
Why are the changes needed?
We should assign proper name to LEGACY_ERROR_TEMP*
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*