[SPARK-40789][PYTHON][TESTS] Separate tests under pyspark.sql.tests #38239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @zhengruifeng @ueshin @grundprinzip @xinrong-meng @itholic please take a look when you guys find some time to review. |
github-actions
bot
added
BUILD
CONNECT
CORE
DOCS
INFRA
PYTHON
SQL
STRUCTURED STREAMING
labels
grundprinzip
approved these changes
Oct 13, 2022
Member
Author
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request?
This PR proposes to split the tests into the sub-packages:
**Before**
```
tests
├── __init__.py
├── test_arrow.py
├── test_arrow_map.py
├── test_catalog.py
├── test_column.py
├── test_conf.py
├── test_connect_basic.py
├── test_connect_column_expressions.py
├── test_connect_plan_only.py
├── test_connect_select_ops.py
├── test_context.py
├── test_dataframe.py
├── test_datasources.py
├── test_functions.py
├── test_group.py
├── test_pandas_cogrouped_map.py
├── test_pandas_grouped_map.py
├── test_pandas_grouped_map_with_state.py
├── test_pandas_map.py
├── test_pandas_udf.py
├── test_pandas_udf_grouped_agg.py
├── test_pandas_udf_scalar.py
├── test_pandas_udf_typehints.py
├── test_pandas_udf_typehints_with_future_annotations.py
├── test_pandas_udf_window.py
├── test_readwriter.py
├── test_serde.py
├── test_session.py
├── test_streaming.py
├── test_streaming_listener.py
├── test_types.py
├── test_udf.py
├── test_udf_profiler.py
├── test_utils.py
└── typing
├── ...
```
**After**
```
tests
├── __init__.py
├── connect
│ ├── __init__.py
│ ├── test_connect_basic.py
│ ├── test_connect_column_expressions.py
│ ├── test_connect_plan_only.py
│ └── test_connect_select_ops.py
├── pandas
│ ├── __init__.py
│ ├── test_pandas_cogrouped_map.py
│ ├── test_pandas_grouped_map.py
│ ├── test_pandas_grouped_map_with_state.py
│ ├── test_pandas_map.py
│ ├── test_pandas_udf.py
│ ├── test_pandas_udf_grouped_agg.py
│ ├── test_pandas_udf_scalar.py
│ ├── test_pandas_udf_typehints.py
│ ├── test_pandas_udf_typehints_with_future_annotations.py
│ └── test_pandas_udf_window.py
├── streaming
│ ├── __init__.py
│ ├── test_streaming.py
│ └── test_streaming_listener.py
├── test_arrow.py
├── test_arrow_map.py
├── test_catalog.py
├── test_column.py
├── test_conf.py
├── test_context.py
├── test_dataframe.py
├── test_datasources.py
├── test_functions.py
├── test_group.py
├── test_readwriter.py
├── test_serde.py
├── test_session.py
├── test_types.py
├── test_udf.py
├── test_udf_profiler.py
├── test_utils.py
└── typing
├── ...
```
This way is consistent with `pyspark.pandas.tests`.
### Why are the changes needed?
To make it easier to maintain, track and add the tests.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out.
Closes apache#38239 from HyukjinKwon/SPARK-40789.
Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org>
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to split the tests into the sub-packages:
Before
After
This way is consistent with
pyspark.pandas.tests.Why are the changes needed?
To make it easier to maintain, track and add the tests.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
CI in this PR should test it out.