[SPARK-40324][SQL] Provide query context in AnalysisException #37841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Sep 9, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 9, 2022
...lyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala
Outdated
Show resolved
Hide resolved
|
cc @dtenedor myself for context |
MaxGekk
approved these changes
Sep 10, 2022
|
+1, LGTM. Merging to master. |
gengliangwang
added a commit
that referenced
this pull request
Sep 14, 2022
…alyzer ### What changes were proposed in this pull request? This is a followup of #37841. The code change in https://github.com/apache/spark/pull/37841/files#diff-ed19f376a63eba52eea59ca71f3355d4495fad4fad4db9a3324aade0d4986a47R212 is wrong. The context of`analyzed.origin` is not accurate at all. Thus this PR is to revert it ### Why are the changes needed? Fix a wrong query context in previous PR #37841 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes #37861 from gengliangwang/fxiReg. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a major PR for extending AnalysisException with query context. After changes, we can:
Why are the changes needed?
Make it possible for better error messages in analysis exceptions.
Does this PR introduce any user-facing change?
No. This is an extension of the framework. We will have more improvements based on this one.
How was this patch tested?
Existing UT