[SPARK-40297][SQL] CTE outer reference nested in CTE main body cannot be resolved #37751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
approved these changes
Sep 1, 2022
|
thanks, merging to master! |
|
It has conflicts in 3.3, due to missing #36146 . @peter-toth can you help to open a backport PR for it? Thanks! |
Sure, I can open it today or tomorrow. |
|
@cloud-fan, here it is: #37760 |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 6, 2022
… be resolved
This PR fixes a bug where a CTE reference cannot be resolved if this reference occurs in an inner CTE definition nested in the outer CTE's main body FROM clause. E.g.,
```
WITH cte_outer AS (
SELECT 1
)
SELECT * FROM (
WITH cte_inner AS (
SELECT * FROM cte_outer
)
SELECT * FROM cte_inner
)
```
This fix is to change the `CTESubstitution`'s traverse order from `resolveOperatorsUpWithPruning` to `resolveOperatorsDownWithPruning` and also to recursively call `traverseAndSubstituteCTE` for CTE main body.
Bug fix. Without the fix an `AnalysisException` would be thrown for CTE queries mentioned above.
No.
Added UTs.
Closes #37751 from maryannxue/spark-40297.
Authored-by: Maryann Xue <maryann.xue@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
backported to 3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a bug where a CTE reference cannot be resolved if this reference occurs in an inner CTE definition nested in the outer CTE's main body FROM clause. E.g.,
This fix is to change the
CTESubstitution's traverse order fromresolveOperatorsUpWithPruningtoresolveOperatorsDownWithPruningand also to recursively calltraverseAndSubstituteCTEfor CTE main body.Why are the changes needed?
Bug fix. Without the fix an
AnalysisExceptionwould be thrown for CTE queries mentioned above.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added UTs.