Skip to content

add ignore for the recently added and failing mypy error 'type-var' SPARK-39811 #37210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add ignore for the recently added and failing mypy error 'type-var' SPARK-39811 #37210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyspark/ml/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def _to_java(self) -> "JavaObject":
return self._java_obj

@staticmethod
def _from_java(java_stage: "JavaObject") -> "JP":
def _from_java(java_stage: "JavaObject") -> "JP": # type: ignore[type-var]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anilbey mind filing a JIRA and linking it into PR title? See also, https://spark.apache.org/contributing.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon here it is
https://issues.apache.org/jira/browse/SPARK-39811

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link it to the PR title, and also please take a look at https://github.com/apache/spark/pull/37210/checks?check_run_id=7379165026

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title now contains "SPARK-39811". Rebasing didn't make a difference on the CI failure.

"""
Given a Java object, create and return a Python wrapper of it.
Used for ML persistence.
Expand Down