[SPARK-39646][SQL] Make setCurrentDatabase compatible with 3 layer namespace #36969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
reviewed
Jun 23, 2022
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
Outdated
Show resolved
Hide resolved
amaliujia
reviewed
Jun 23, 2022
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
changed the title
Member
|
cc @zhengruifeng FYI |
|
Can one of the admins verify this patch? |
zachschuermann
force-pushed
the
3l-setCurrentDatabse
branch
from
ae54456 to
ce30e89
Compare
amaliujia
reviewed
Jun 28, 2022
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala
Outdated
Show resolved
Hide resolved
zachschuermann
changed the title
zachschuermann
force-pushed
the
3l-setCurrentDatabse
branch
from
ce30e89 to
9e9a563
Compare
Contributor
|
R: @cloud-fan |
cloud-fan
approved these changes
Jul 1, 2022
Contributor
|
@schuermannator there are some conflicts to reslove. |
zachschuermann
force-pushed
the
3l-setCurrentDatabse
branch
from
c3fcc66 to
8a58c03
Compare
Contributor
|
SparkR failed: |
Contributor
Author
|
good to go now! |
Contributor
|
Merged to master! |
3 tasks
pan3793
pushed a commit
to apache/kyuubi
that referenced
this pull request
Jul 4, 2022
### _Why are the changes needed?_ To make the behavior consistent. The master GA failed due to apache/spark#36969 <img width="1137" alt="image" src="https://user-images.githubusercontent.com/12025282/177069041-b0a102ca-51bf-4faf-b89d-53bfd950cbc2.png"> ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2998 from ulysses-you/setCurrentNamespace. Closes #2997 2646d4f [ulysses-you] style 79a9f33 [ulysses-you] simplify 246ed71 [ulysses-you] v2 catalog Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
setCurrentDatabasecatalog API to support 3 layer namespace. We usesparkSession.sessionState.catalogManager.currentNamespacefor the currentDatabase now.Why are the changes needed?
setCurrentDatabasedoesn't support 3 layer namespace.Does this PR introduce any user-facing change?
Yes. This PR introduces a backwards-compatible API change to support 3 layer namespace (e.g. catalog.database.table) for
setCurrentDatabase.How was this patch tested?
UT