Skip to content

[SPARK-39437][FOLLOWUP][SQL][TESTS] Update q83.ansi result #36836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-39437][FOLLOWUP][SQL][TESTS] Update q83.ansi result #36836

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 10, 2022

What changes were proposed in this pull request?

This is a follow-up of #36827 to update q83.ansi result.

Why are the changes needed?

ANSI mode unit tests are not covered on GitHub Action on PRs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This should be tested manually because GitHub Action doesn't test this.

$ SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly *PlanStabilitySuite"

@github-actions github-actions bot added the SQL label Jun 10, 2022
@dongjoon-hyun
Copy link
Member Author

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need same update for other branches?

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jun 10, 2022

Yes for branch-3.3 but there is no open PR for branch-3.3.
For branch-3.2, we don't have SPARK_ANSI_SQL_MODE there. So, we don't need.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya and @gengliangwang . This is a test-only PR which is isolated a single test case. And, I verified this. Merged to master to recover the CIs.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-39437 branch June 10, 2022 20:51
@huaxingao
Copy link
Contributor

Late LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @huaxingao !

@dongjoon-hyun
Copy link
Member Author

Oh, my bad. I missed that we have another failure in PlanStabilityWithStatsSuite too. 😞

@dongjoon-hyun
Copy link
Member Author

Here is another PR for ANSI mode PlanStabilityWithStatsSuite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants