Skip to content

Revert "[SPARK-37670][SQL] Support predicate pushdown and column pruning for de-duped CTEs" #36819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 9, 2022

What changes were proposed in this pull request?

This reverts 1a35685 except transformDownWithSubqueries because SPARK-39259 starts to use it.

Why are the changes needed?

Currently, branch-3.2 is broken.

Screen Shot 2022-06-08 at 7 25 46 PM

Screen Shot 2022-06-08 at 7 25 55 PM

Here is the AS-IS result generation status.

$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite" &> /dev/null
$ git status
On branch branch-3.2
Your branch is up to date with 'apache/branch-3.2'.

nothing to commit, working tree clean
  • In addition, the result is different when we run the test individually.
$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite -- -z (tpcds-v1.4/q4)" &> /dev/null
$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite -- -z (tpcds-v1.4/q5)" &> /dev/null
$ git diff --stat
 sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q4/explain.txt | 238 ++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------
 sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q5/explain.txt | 212 ++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------
 2 files changed, 225 insertions(+), 225 deletions(-)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the SQL label Jun 9, 2022
@dongjoon-hyun dongjoon-hyun marked this pull request as draft June 9, 2022 08:23
@dongjoon-hyun dongjoon-hyun changed the title Revert "[SPARK-39393][SQL] Parquet data source only supports push-down predicate filters for non-repeated primitive types" Revert "[SPARK-37670][SQL] Support predicate pushdown and column pruning for de-duped CTEs" Jun 9, 2022
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review June 9, 2022 09:35
@dongjoon-hyun
Copy link
Member Author

To reviewers, this will wait for @cloud-fan 's PR to fix the PlanStabilitySuite.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jun 10, 2022

Gentle ping, @cloud-fan . I hope to recover the branch-3.2 first.

@cloud-fan
Copy link
Contributor

I have created the PR for 3.2: #36828

Can we wait for a few more hours?

@dongjoon-hyun
Copy link
Member Author

Thank you. The patch looks good to me.

I close this PR in favor of #36828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants