[SPARK-38985][SQL] Add sub error classes #36307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
from
33c8d42 to
f1bb2f7
Compare
HyukjinKwon
changed the title
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
2 times, most recently
from
53f9637 to
ab7b64a
Compare
|
Can one of the admins verify this patch? |
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
3 times, most recently
from
c5a3736 to
645bcec
Compare
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
3 times, most recently
from
6d8f694 to
ae80a6f
Compare
|
@cloud-fan @MaxGekk Other than that this is ready to go. |
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
from
ae80a6f to
c9b723c
Compare
srielau
force-pushed
the
SPARK-38985-sub-error-classes
branch
from
c9b723c to
a4eb0b6
Compare
|
@MaxGekk @cloud-fan All clean now, can you please review and merge it if you agree. |
MaxGekk
requested changes
Apr 24, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 26, 2022
cloud-fan
reviewed
Apr 26, 2022
cloud-fan
reviewed
Apr 26, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 26, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
…xecutionErrors.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
…xecutionErrors.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
srielau
commented
Apr 26, 2022
srielau
commented
Apr 26, 2022
srielau
commented
Apr 26, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
…tionErrorsSuite.scala
cloud-fan
approved these changes
Apr 27, 2022
|
thanks, merging to master! |
This was referenced Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We support nesting an optional map of "sub error classes" in error-classes.json.
Each sub class has a distinct message and independent parameters.
Why are the changes needed?
A select subset of error classes have a large variety of error messages which cannot be easily tokenized.
But we do not want to split them because the conditions are often temporary. An example is UNSUPPORTED_FEATURE.
Supporting nested error classes allows us to keep the variety of messages without exploding the number of error classes.
Does this PR introduce any user-facing change?
Yes, we will change the error message texts
How was this patch tested?
Run all affected error test suites.