[SPARK-38925][BUILD] Update guava to 30.1.1-jre #36231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoliversun
changed the title
dcoliversun
force-pushed
the
SPARK-38925
branch
from
f71a844 to
3bc4558
Compare
|
Can one of the admins verify this patch? |
|
IIRC, the problem was that Hadoop 2 compatibility which doesn't support higher Guava version. it would be great to check if it compiles and the tests pass fine w/ Hadoop 2 profile. |
|
@HyukjinKwon OK, I will test compatibility with Hadoop 2. |
|
@HyukjinKwon Yes, there is a conflict between hadoop 2 and guava higher version. Guava is the Google core library for Java that is used by many libraries and frameworks, including Hadoop. A dependency conflict can occur if a job or its dependencies require a version of Guava that is newer than the one used by Hadoop. Hadoop v3.0 resolved this issue. |
Closed
|
Hadoop 2 is dropped in the binary release. Maybe we should try it upgrade it now |
|
cc @dongjoon-hyun FYI. cc @hvanhovell @zsxwing @grundprinzip @cloud-fan @bozhang2820 @amaliujia FYI |
|
cc @JoshRosen @tgravescs too fyi |
|
I think not only Hadoop, the problem also comes from Hive 2.3 dependency. Please see #33989. In summary, to combat against the issue, we'll need to create shaded Hive in a separate place and be consumed by Spark, similar to how Hadoop handles Guava in hadoop-thirdparty. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2024
### What changes were proposed in this pull request? This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) ### Why are the changes needed? It's a long-standing issue, see prior discussions at #35584, #36231, and #33989 ### Does this PR introduce _any_ user-facing change? Yes, some user-faced error messages changed. ### How was this patch tested? GA passed. Closes #42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) ### Why are the changes needed? It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 ### Does this PR introduce _any_ user-facing change? Yes, some user-faced error messages changed. ### How was this patch tested? GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) ### Why are the changes needed? It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 ### Does this PR introduce _any_ user-facing change? Yes, some user-faced error messages changed. ### How was this patch tested? GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
prabhjyotsingh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Feb 8, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d)
prabhjyotsingh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Feb 8, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d)
prabhjyotsingh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Feb 8, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d)
prabhjyotsingh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Feb 8, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d) (cherry picked from commit e5cc252)
shubhluck
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
May 16, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d)
senthh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
May 26, 2025
This PR upgrades Spark's built-in Guava from 14 to 33.2.1-jre Currently, Spark uses Guava 14 because the previous built-in Hive 2.3.9 is incompatible with new Guava versions. HIVE-27560 (apache/hive#4542) makes Hive 2.3.10 compatible with Guava 14+ (thanks to LuciferYang) It's a long-standing issue, see prior discussions at apache#35584, apache#36231, and apache#33989 Yes, some user-faced error messages changed. GA passed. Closes apache#42493 from pan3793/guava. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1f24b2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates guava to 30.1.1-jre.
Why are the changes needed?
guava 14.0.1 has two risks:
And API in guava 14.0.1 used by apache spark is labeled as
Beta, such asBaseEncodinginDriverKubernetesCredentialsFeatureStep. In 30.1.1-jre, these APIs have been removed labelBeta.More information: https://github.com/google/guava/releases/tag/v30.1.1
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the GA