-
Notifications
You must be signed in to change notification settings - Fork 28.6k
SPARK-2143 [WEB UI] Add Spark version to UI footer #3410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #23730 has started for PR 3410 at commit
|
Big +1 on putting the Spark version somewhere in all the various webuis. I probably wouldn't put it that big in the header, but definitely somewhere. |
Test build #23730 has finished for PR 3410 at commit
|
Test PASSed. |
Sure, I'm open to suggestions to make it subtler. This is just what the simplest thing looks like. Smaller text in the same place? or same size but with more separation? lighter gray? |
A footer might be nice. Maybe the text it the footer could be in a more subdued grey (and possibly darken on hover)? |
Test build #23765 has started for PR 3410 at commit
|
Test build #23765 has finished for PR 3410 at commit
|
Test PASSed. |
This seem good to me; mind updating the PR title / description to say "footer" instead of "header"? |
LGTM! I'm going to pull this into the backport branches, too. |
This PR adds the Spark version number to the UI footer; this is how it looks:  Author: Sean Owen <sowen@cloudera.com> Closes #3410 from srowen/SPARK-2143 and squashes the following commits: e9b3a7a [Sean Owen] Add Spark version to footer
This PR adds the Spark version number to the UI footer; this is how it looks:  Author: Sean Owen <sowen@cloudera.com> Closes #3410 from srowen/SPARK-2143 and squashes the following commits: e9b3a7a [Sean Owen] Add Spark version to footer
Doh! I just realized that my |
I took a very basic stab at adding the Spark version number to the UI header / footer. This is the simplest place I could think to stick it without getting into the CSS much, and this is how it looks:
Thoughts? I think it's nice to have in the UI but might need to look a little different.