Skip to content

SPARK-2143 [WEB UI] Add Spark version to UI footer #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Nov 21, 2014

I took a very basic stab at adding the Spark version number to the UI header / footer. This is the simplest place I could think to stick it without getting into the CSS much, and this is how it looks:

screen shot 2014-11-21 at 22 58 40

Thoughts? I think it's nice to have in the UI but might need to look a little different.

@srowen srowen changed the title Add Spark version to UI header SPARK-2143 [WEB UI] Add Spark version to UI header Nov 21, 2014
@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23730 has started for PR 3410 at commit 74c42c2.

  • This patch merges cleanly.

@ash211
Copy link
Contributor

ash211 commented Nov 21, 2014

Big +1 on putting the Spark version somewhere in all the various webuis. I probably wouldn't put it that big in the header, but definitely somewhere.

@SparkQA
Copy link

SparkQA commented Nov 22, 2014

Test build #23730 has finished for PR 3410 at commit 74c42c2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23730/
Test PASSed.

@srowen
Copy link
Member Author

srowen commented Nov 22, 2014

Sure, I'm open to suggestions to make it subtler. This is just what the simplest thing looks like.

Smaller text in the same place? or same size but with more separation? lighter gray?
I could try to establish a footer with this info; there isn't a footer, yet.

@JoshRosen
Copy link
Contributor

A footer might be nice. Maybe the text it the footer could be in a more subdued grey (and possibly darken on hover)?

@srowen
Copy link
Member Author

srowen commented Nov 23, 2014

Done, it's now a footer. I just used the simple footer example from bootstrap too, which happens to be gray as well. Nothing fancy.

screen shot 2014-11-23 at 13 42 22

@SparkQA
Copy link

SparkQA commented Nov 23, 2014

Test build #23765 has started for PR 3410 at commit e9b3a7a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 23, 2014

Test build #23765 has finished for PR 3410 at commit e9b3a7a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23765/
Test PASSed.

@JoshRosen
Copy link
Contributor

This seem good to me; mind updating the PR title / description to say "footer" instead of "header"?

@srowen srowen changed the title SPARK-2143 [WEB UI] Add Spark version to UI header SPARK-2143 [WEB UI] Add Spark version to UI footer Nov 29, 2014
@JoshRosen
Copy link
Contributor

LGTM! I'm going to pull this into the backport branches, too.

@asfgit asfgit closed this in 048ecca Nov 30, 2014
asfgit pushed a commit that referenced this pull request Nov 30, 2014
This PR adds the Spark version number to the UI footer; this is how it looks:

![screen shot 2014-11-21 at 22 58 40](https://cloud.githubusercontent.com/assets/822522/5157738/f4822094-7316-11e4-98f1-333a535fdcfa.png)

Author: Sean Owen <sowen@cloudera.com>

Closes #3410 from srowen/SPARK-2143 and squashes the following commits:

e9b3a7a [Sean Owen] Add Spark version to footer
asfgit pushed a commit that referenced this pull request Nov 30, 2014
This PR adds the Spark version number to the UI footer; this is how it looks:

![screen shot 2014-11-21 at 22 58 40](https://cloud.githubusercontent.com/assets/822522/5157738/f4822094-7316-11e4-98f1-333a535fdcfa.png)

Author: Sean Owen <sowen@cloudera.com>

Closes #3410 from srowen/SPARK-2143 and squashes the following commits:

e9b3a7a [Sean Owen] Add Spark version to footer
@JoshRosen
Copy link
Contributor

Doh! I just realized that my branch-1.1 cherry pick is going to break the build since prior to Spark 1.2 SPARK_VERSION was only defined in the SparkContext companion object rather than in the Spark package object. I'll push a hotfix to fix that now.

@srowen srowen deleted the SPARK-2143 branch December 3, 2014 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants