[SPARK-32577][SQL][TEST] Fix the config value for shuffled hash join in test in-joins.sql #33236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan, thanks. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #140720 has finished for PR 33236 at commit
|
cloud-fan
approved these changes
Jul 7, 2021
|
are there more places that need to fix? |
HyukjinKwon
approved these changes
Jul 7, 2021
|
It seems not searchable in repo, let me try to figure out all places tomorrow. Thanks. |
|
let me just merge it in then. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 7, 2021
…in test in-joins.sql ### What changes were proposed in this pull request? We found the `in-join.sql` does not test shuffled hash join properly in https://issues.apache.org/jira/browse/SPARK-32577, but didn't find a good way to fix it. Given we now have a test config to enforce shuffled hash join in #33182, we can fix the test here now as well. ### Why are the changes needed? Fix test to have better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Reran the test to compare the output, and verified the query plan manually to make sure shuffled hash join being used. Closes #33236 from c21/join-test. Authored-by: Cheng Su <chengsu@fb.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f3c1159) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
Merged to master and branch-3.2. |
|
Thank you @HyukjinKwon and @cloud-fan for review! Will submit another PR for other changes. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 8, 2021
…ash join for all other test queries ### What changes were proposed in this pull request? This is the followup from #33236 (comment), where we are fixing the config value of shuffled hash join, for all other test queries. Found all configs by searching in https://github.com/apache/spark/search?q=spark.sql.join.preferSortMergeJoin . ### Why are the changes needed? Fix test to have better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #33249 from c21/join-test. Authored-by: Cheng Su <chengsu@fb.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 8, 2021
…ash join for all other test queries ### What changes were proposed in this pull request? This is the followup from #33236 (comment), where we are fixing the config value of shuffled hash join, for all other test queries. Found all configs by searching in https://github.com/apache/spark/search?q=spark.sql.join.preferSortMergeJoin . ### Why are the changes needed? Fix test to have better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #33249 from c21/join-test. Authored-by: Cheng Su <chengsu@fb.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 23943e5) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We found the
in-join.sqldoes not test shuffled hash join properly in https://issues.apache.org/jira/browse/SPARK-32577, but didn't find a good way to fix it. Given we now have a test config to enforce shuffled hash join in #33182, we can fix the test here now as well.Why are the changes needed?
Fix test to have better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Reran the test to compare the output, and verified the query plan manually to make sure shuffled hash join being used.