[SPARK-35609][BUILD] Add style rules to prohibit to use a Guava's API which is incompatible with newer versions

[sarutak]

What changes were proposed in this pull request?

This PR adds rules to checkstyle.xml and scalastyle-config.xml to avoid introducing Objects.toStringHelper a Guava's API which is no longer present in newer Guava.

Why are the changes needed?

SPARK-30272 (#26911) replaced Objects.toStringHelper which is an APIs Guava 14 provides with commons.lang3 API because Objects.toStringHelper is no longer present in newer Guava.
But toStringHelper was introduced into Spark again and replaced them in SPARK-35420 (#32567).
I think it's better to have a style rule to avoid such repetition.

SPARK-30272 replaced some APIs aside from Objects.toStringHelper but Objects.toStringHelper seems to affect Spark for now so I add rules only for it.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I confirmed that lint-java and lint-scala detect the usage of toStringHelper and let the lint check fail.

$ dev/lint-java
exec: curl --silent --show-error -L https://downloads.lightbend.com/scala/2.12.14/scala-2.12.14.tgz
Using `mvn` from path: /opt/maven/3.6.3//bin/mvn
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/network/protocol/OneWayMessage.java:[78] (regexp) RegexpSinglelineJava: Avoid using Object.toStringHelper. Use ToStringBuilder instead.

$ dev/lint-scala 
Scalastyle checks failed at following occurrences:
[error] /home/kou/work/oss/spark/core/src/main/scala/org/apache/spark/rdd/RDD.scala:93:25: Avoid using Object.toStringHelper. Use ToStringBuilder instead.
[error] Total time: 25 s, completed 2021/06/02 16:18:25

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43728/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43728/

[SparkQA]

Test build #139205 has finished for PR 32740 at commit 0252b1e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Seems reasonable to prohibit this particular method - we dont' use it anymore in the code now?

[sarutak]

I think, we have no more use of Objects.toStringHelper for now.
lint-java and lint-scala passed and I also confirmed with the following commands.

build/mvn -Phive -Phive-thriftserver -Pkubernetes -Pyarn -Pmesos -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pkinesis-asl -Phadoop-cloud checkstyle:check | grep ERROR

build/sbt -Phive -Phive-thriftserver -Pkubernetes -Pyarn -Pmesos -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pkinesis-asl -Phadoop-cloud scalastyle test:scalastyle

[sarutak]

Merged to master.