-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-35206][TESTS][SQL] Extract common used get project path into a function in SparkFunctionSuite #32315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @cloud-fan @yhuai please take a look, thanks! |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #137864 has finished for PR 32315 at commit
|
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/SQLKeywordSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #137868 has finished for PR 32315 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #137888 has finished for PR 32315 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #137897 has finished for PR 32315 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #137910 has finished for PR 32315 at commit
|
62b7890 to
6e70fdd
Compare
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138537 has finished for PR 32315 at commit
|
|
looks good, can you update the PR description? |
Updated, thanks! |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138556 has finished for PR 32315 at commit
|
|
thanks, merging to master! |
What changes were proposed in this pull request?
Add a common functions
getWorkspaceFilePath(which prefixed with spark home) toSparkFunctionSuite, and applies these the function to where they're extracted from.Why are the changes needed?
Spark sql has test suites to read resources when running tests. The way of getting the path of resources is commonly used in different suites. We can extract them into a function to ease the code maintenance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass existing tests.