Skip to content

Conversation

@Ngone51
Copy link
Member

@Ngone51 Ngone51 commented Apr 23, 2021

What changes were proposed in this pull request?

Add a common functions getWorkspaceFilePath (which prefixed with spark home) to SparkFunctionSuite, and applies these the function to where they're extracted from.

Why are the changes needed?

Spark sql has test suites to read resources when running tests. The way of getting the path of resources is commonly used in different suites. We can extract them into a function to ease the code maintenance.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass existing tests.

@Ngone51
Copy link
Member Author

Ngone51 commented Apr 23, 2021

cc @cloud-fan @yhuai please take a look, thanks!

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42394/

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Test build #137864 has finished for PR 32315 at commit 7b70d5e.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait SQLKeywordUtils extends SparkFunSuite with SQLHelper
  • class SQLKeywordSuite extends SQLKeywordUtils
  • class TableIdentifierParserSuite extends SQLKeywordUtils

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Test build #137868 has finished for PR 32315 at commit 3b3e51f.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42398/

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42414/

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Test build #137888 has finished for PR 32315 at commit 9a6824b.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42422/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42422/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Test build #137897 has finished for PR 32315 at commit c02199c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42434/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42434/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Test build #137910 has finished for PR 32315 at commit 62b7890.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Ngone51 Ngone51 force-pushed the extract-common-file-path branch from 62b7890 to 6e70fdd Compare May 14, 2021 02:01
@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43058/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43058/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138537 has finished for PR 32315 at commit 6e70fdd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

looks good, can you update the PR description?

@Ngone51
Copy link
Member Author

Ngone51 commented May 14, 2021

looks good, can you update the PR description?

Updated, thanks!

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43077/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43077/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138556 has finished for PR 32315 at commit 1f74017.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan closed this in 94bd480 May 14, 2021
@cloud-fan
Copy link
Contributor

thanks, merging to master!

@Ngone51 Ngone51 deleted the extract-common-file-path branch May 14, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants