[MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState #32162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors three parts of the comments in
HiveClientImpl.withHiveStateOne is about the following comment.
The comment was added in SPARK-10810 (#8909) because
IsolatedClientLoader.classLoaderwas declared asvar.But the field is now
valand cannot be changed after instanciation.So, the comment can confuse developers.
One is about the following code and comment.
It's not trivial why this part is necessary and it's difficult when we can remove this code in the future.
So, I revised the comment by adding the reference of the related JIRA.
And the last one is about the following code and comment.
It's also not trivial why this part is necessary.
I revised the comment by adding the reference of the related discussion.
Why are the changes needed?
To make code more readable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
It's just a comment refactoring so I add no new test.