Skip to content

[WIP][SPARK-32833][SQL] JDBC V2 Datasource aggregate push down #32061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

baibaichen
Copy link
Contributor

What changes were proposed in this pull request?

This PR refactor #29695, it has some limitations in terms of implementation and abstraction:

  1. Don't support count
  2. Don't support AVG in case of multiple partitions, and actually the current implementation is wrong even in single partition.
  3. Don't know how to extend for supporting more aggregation case, for example, sum(if()).
  4. Don’t know how to extend for supporting join push down

see the discussion here, The SPIP PDF could be viewed here.

Why are the changes needed?

for better performance

Does this PR introduce any user-facing change?

No

How was this patch tested?

using tests from #29695

@github-actions github-actions bot added the SQL label Apr 6, 2021
@baibaichen
Copy link
Contributor Author

cc @huaxingao

@baibaichen baibaichen force-pushed the feature/AggPushDown branch from 568d726 to be4e673 Compare April 6, 2021 10:35
@baibaichen baibaichen force-pushed the feature/AggPushDown branch from be4e673 to 75f8fdc Compare April 6, 2021 16:22
@wangyum
Copy link
Member

wangyum commented Apr 7, 2021

ok to test.

@wangyum
Copy link
Member

wangyum commented Apr 7, 2021

add to whitelist.

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41554/

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41554/

@baibaichen
Copy link
Contributor Author

ok to test.

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41568/

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41568/

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Test build #136977 has finished for PR 32061 at commit 75f8fdc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class JDBCTableCatalog extends TableCatalog with SupportsNamespaces with SupportsSQL with Logging
  • abstract sealed class PushQuery extends Logging
  • class OldPush (
  • case class PushScanQuery(
  • case class PushAggregateQuery(
  • case class SingleSQLStatement(
  • case class SingleCatalystStatement(

@SparkQA
Copy link

SparkQA commented Apr 7, 2021

Test build #136991 has finished for PR 32061 at commit dcc16a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43714/

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43714/

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Sep 20, 2021
@github-actions github-actions bot closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants