[SPARK-33212][FOLLOW-UP][BUILD] Uses provided properties for Hadoop client dependencies in root pom #31467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sunchao would you mind taking a quick look please? |
sunchao
approved these changes
Feb 4, 2021
|
Nah, it's just a cleanup. Thanks for taking a look 😄 |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #134855 has finished for PR 31467 at commit
|
|
Merged to master. |
|
Thank you, @HyukjinKwon and @sunchao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #30701. It uses properties of
hadoop-client-api.artifact,hadoop-client-runtime.artifactandhadoop-client-minicluster.artifactexplicitly to set the dependencies and versions.Otherwise, it is logically incorrect. For example, if you build with Hadoop 2, this dependency becomes
hadoop-client-api:2.7.4internally, which does not exist in Hadoop 2 (https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-client-api).Why are the changes needed?
generate-sourcesplugin is used together with Hadoop 2 by default, which attempts to pull 2.7.4 ofhadoop-client-api,hadoop-client-runtimeandhadoop-client-miniclusterfor whatever reason.Does this PR introduce any user-facing change?
No for users and dev. It's more a cleanup.
How was this patch tested?
Manually checked the dependencies are correctly placed.