Skip to content

[SPARK-4254] [mllib] MovieLensALS bug fix #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jkbradley
Copy link
Member

Changed code so it does not try to serialize Params.
CC: @mengxr @debasish83 @srowen

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22945 has started for PR 3116 at commit 9401b16.

  • This patch merges cleanly.

@debasish83
Copy link

should we make AbstractParam serializable instead ?

@jkbradley
Copy link
Member Author

I tried that first and ran into issues still. I'm not sure why it doesn't work to have Params and AbstractParams be Serializable.

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22945 has finished for PR 3116 at commit 9401b16.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22945/
Test FAILed.

@srowen
Copy link
Member

srowen commented Nov 5, 2014

LGTM.

@jkbradley
Copy link
Member Author

Thanks! Pushed merge with master so it re-runs tests. (Failure was with YARN)

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22951 has started for PR 3116 at commit e575bd8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22951 has finished for PR 3116 at commit e575bd8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22951/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Nov 6, 2014

Merged into master and branch-1.2 Thanks!

asfgit pushed a commit that referenced this pull request Nov 6, 2014
Changed code so it does not try to serialize Params.
CC: mengxr 	debasish83 srowen

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #3116 from jkbradley/als-bugfix and squashes the following commits:

e575bd8 [Joseph K. Bradley] Merge remote-tracking branch 'upstream/master' into als-bugfix
9401b16 [Joseph K. Bradley] changed implicitPrefs so it is not serialized to fix MovieLensALS example bug

(cherry picked from commit c315d13)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in c315d13 Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants