-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-4254] [mllib] MovieLensALS bug fix #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #22945 has started for PR 3116 at commit
|
should we make AbstractParam serializable instead ? |
I tried that first and ran into issues still. I'm not sure why it doesn't work to have Params and AbstractParams be Serializable. |
Test build #22945 has finished for PR 3116 at commit
|
Test FAILed. |
LGTM. |
Thanks! Pushed merge with master so it re-runs tests. (Failure was with YARN) |
Test build #22951 has started for PR 3116 at commit
|
Test build #22951 has finished for PR 3116 at commit
|
Test PASSed. |
Merged into master and branch-1.2 Thanks! |
Changed code so it does not try to serialize Params. CC: mengxr debasish83 srowen Author: Joseph K. Bradley <joseph@databricks.com> Closes #3116 from jkbradley/als-bugfix and squashes the following commits: e575bd8 [Joseph K. Bradley] Merge remote-tracking branch 'upstream/master' into als-bugfix 9401b16 [Joseph K. Bradley] changed implicitPrefs so it is not serialized to fix MovieLensALS example bug (cherry picked from commit c315d13) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Changed code so it does not try to serialize Params.
CC: @mengxr @debasish83 @srowen