Skip to content

[SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1 #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

coderfi
Copy link
Contributor

@coderfi coderfi commented Nov 3, 2014

Simple pom.xml update.

instead of the Spark compatible `hive.version=0.13.1a`
Note: `hive.version=0.13.1a` is the default version.
However, when explicitly specifying the `hive-0.13.1` maven profile, the
wrong one would be selected.
e.g. mvn -Phive -Phive=0.13.1
See PR #2685
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@liancheng
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Nov 3, 2014

Test build #22809 has started for PR 3072 at commit 7ca4b1e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 3, 2014

Test build #22809 has finished for PR 3072 at commit 7ca4b1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22809/
Test PASSed.

@liancheng
Copy link
Contributor

@coderfi Would you please file a JIRA ticket for this and then rename the title of this PR to something like "[SPARK-9999][Build] Fixes hive.version in Maven profile hive-0.13.1"?

@liancheng
Copy link
Contributor

This LGTM besides PR title and the missing JIRA ticket. Thanks!

@coderfi
Copy link
Contributor Author

coderfi commented Nov 3, 2014

Hello,

I'll file a ticket.
Suggestion on the title? oops, didn't see your above note

Fi
On Nov 3, 2014 2:09 AM, "Cheng Lian" notifications@github.com wrote:

This LGTM besides PR title and the missing JIRA ticket. Thanks!


Reply to this email directly or view it on GitHub
#3072 (comment).

@coderfi coderfi changed the title The hive-0.13.1 maven profile now sets hive.version=0.13.1a [SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1 Nov 3, 2014
@pwendell
Copy link
Contributor

pwendell commented Nov 3, 2014

LGTM

@marmbrus
Copy link
Contributor

marmbrus commented Nov 3, 2014

Thanks! Merged to master.

asfgit pushed a commit that referenced this pull request Nov 3, 2014
instead of `hive.version=0.13.1`.
e.g. mvn -Phive -Phive=0.13.1

Note: `hive.version=0.13.1a` is the default property value. However, when explicitly specifying the `hive-0.13.1` maven profile, the wrong one would be selected.
References:  PR #2685, which resolved a package incompatibility issue with Hive-0.13.1 by introducing a special version Hive-0.13.1a

Author: fi <coderfi@gmail.com>

Closes #3072 from coderfi/master and squashes the following commits:

7ca4b1e [fi] Fixes the `hive-0.13.1` maven profile referencing `hive.version=0.13.1` instead of the Spark compatible `hive.version=0.13.1a` Note: `hive.version=0.13.1a` is the default version. However, when explicitly specifying the `hive-0.13.1` maven profile, the wrong one would be selected. e.g. mvn -Phive -Phive=0.13.1 See PR #2685

(cherry picked from commit df607da)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in df607da Nov 3, 2014
@coderfi
Copy link
Contributor Author

coderfi commented Nov 3, 2014

Glad to be of service. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants